Skip to content

Add a message for app updates trough occ when no updates available - #40538

Merged
skjnldsv merged 1 commit into
masterfrom
occAppUpdatesReturn
Feb 24, 2024
Merged

Add a message for app updates trough occ when no updates available#40538
skjnldsv merged 1 commit into
masterfrom
occAppUpdatesReturn

Conversation

@solracsf

@solracsfsolracsf commented Sep 20, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Return a message when no updates are available or have been found.

Can be useful to both inform the user that updates have been performed but none found and for scripting, instead of an empty output (and return 0).

# occ app:update contacts
contacts is up-to-date or no updates could be found
# occ app:update --all
All apps are up-to-date or no updates could be found

Checklist

@solracsfsolracsf added the 3. to review Waiting for reviews label Sep 20, 2023
@solracsfsolracsf added this to the Nextcloud 28 milestone Sep 20, 2023
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 20, 2023
View reviewed changes
Comment threadcore/Command/App/Update.php Fixed
Comment threadcore/Command/App/Update.php Fixed
@solracsf
solracsfforce-pushed the occAppUpdatesReturn branch 2 times, most recently from 13a70f6 to 8f6421fCompareSeptember 20, 2023 15:31
@solracsfsolracsf changed the title Add a return message for app updates trough occ when no updates availableAdd a message for app updates trough occ when no updates availableSep 21, 2023
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@skjnldsv
skjnldsv requested review from a team, blizzz, come-nc, nfebe and sorbaugh and removed request for a teamFebruary 23, 2024 20:49
@solracsf@skjnldsv
Add a return message for app updates trough occ
6dfe3c9
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Handle single and all apps
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Rewrite logic
Fix psalm
Fix psalm
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@github-actions

This comment was marked as resolved.

Sign in to view
@skjnldsv
skjnldsv merged commit 167d0d1 into masterFeb 24, 2024
@skjnldsv
skjnldsv deleted the occAppUpdatesReturn branch February 24, 2024 10:25
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebenfebenfebe approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@blizzzblizzzAwaiting requested review from blizzzblizzz is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nc

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: apps managementfeature: install and updatefeature: occ

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

6 participants

@solracsf@nfebe@skjnldsv@github-advanced-security@joshtrichards@blizzz