feat(user status): automate user status for events by miaulalala · Pull Request #40615 · nextcloud/server

miaulalala · 2023-09-25T12:53:03Z

Resolves: Set user status to busy when own calendar contains busy event #31177

Summary

The user status currently only takes into account the availability settings. Automatically set a user status to free or busy depending on their calendar transparency, event status and availability settings combined.

This can be done with a free/busy request just like the Calendar app does for the free/busy modal.

How to test:

THe easiest way to test is to create 5- minute calendar events and have some sort of VAVAILABLITY setting.

The decision tree is the following:

Status decision tree:

USER DEFINED STATUS

Persistent status such as DND, OFFLINE, INVISIBLE?
- leave the status alone
Not persistent?
- get Calendar status
  - calendar checks for events (BUSY) and availability (within the availability and no event = ONLINE, event = AWAY + in a meeting status, outside availability = BUSY + away status)
  - calendar reports identical to existing status (i.e. online == online)
    - leave status alone
  - calendar status is different (i. e. user has status ONLINE but calendar reports AWAY or BUSY)
    - process the new calendar status - in a meeting if a event is happening, away if outside availability

NOT USER DEFINED

get calendar status
process the new calendar status - in a meeting if a event is happening, away if outside availability

TODO

tests

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
~~Screenshots before/after for front-end changes~~
Documentation (manuals or wiki) has been updated or is not required
~~Backports requested where applicable (ex: critical bugfixes)~~

github-advanced-security

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

miaulalala · 2023-10-13T07:45:56Z

Having nextcloud/calendar#3193 would be good @ChristophWurst - shall I add it as a followup?

Context:

nimishavijay · 2023-10-25T13:55:12Z

I think the status alignment with teams needs to be a separate ticket and is not within the scope of this feature.

Would it not be possible to just change the icons for all the statuses?
New icons:
Available: check-circle in --color-success
Busy: circle in --color-error
Away: watch-later in --color-warning
DND: do-not-disturb-on in --color-error
Offline: trip-origin in --color-text-maxcontrast

jancborchardt · 2023-10-25T14:59:46Z

Agree with @nimishavijay. If that is out of scope, a good first step would be to just do the same that we do when in a call – which is not changing the status, only emoji and status text, right @nickvergessen?

nickvergessen · 2023-10-25T15:21:57Z

which is not changing the status, only emoji and status text, right

We do change the status to "Away" (when the user was not invisible (=> no status change) or DND (=> in call with DND))
https://github.com/nextcloud/spreed/blob/3ce5c7bdaafeb8f4747f7bc05e60ebd33ada192a/lib/Status/Listener.php#L55-L83

miaulalala · 2023-11-06T10:36:51Z

Agree with @nimishavijay. If that is out of scope, a good first step would be to just do the same that we do when in a call – which is not changing the status, only emoji and status text, right @nickvergessen?

Aight, chaningin the status to "away" for now, and removing the icons. Follow up ticket for icon changes discussion here:#41299

ChristophWurst

Code looks good

ChristophWurst

Worked for my local instance once I cleared the Away override and the custom status message

and automatically set a user status to free or busy depending on their calendar transparency, event status and availability settings Signed-off-by: Anna Larch <anna@nextcloud.com>

miaulalala · 2023-11-09T17:01:53Z

Failing Cypress test: theming/admin-settings.cy.ts (unrelated)

miaulalala self-assigned this Sep 25, 2023

miaulalala added 2. developing Work in progress feature: status feature: caldav Related to CalDAV internals enhancement pending documentation This pull request needs an associated documentation update labels Sep 25, 2023

miaulalala added this to the Nextcloud 28 milestone Sep 25, 2023

github-advanced-securityAI found potential problems Sep 25, 2023
View reviewed changes

github-advanced-securityAI found potential problems Oct 3, 2023
View reviewed changes

miaulalala force-pushed the enh/automate-calendar-event-user-status branch from fca0790 to f4cfa4dCompare October 3, 2023 14:43

github-advanced-securityAI found potential problems Oct 3, 2023
View reviewed changes

Comment threadapps/user_status/lib/Service/StatusService.php Fixed
Comment threadapps/user_status/lib/Service/StatusService.php Fixed
Comment threadapps/user_status/lib/Service/StatusService.php Fixed

github-advanced-securityAI found potential problems Oct 3, 2023
View reviewed changes

Comment threadapps/user_status/lib/Service/StatusService.php Fixed

miaulalala force-pushed the enh/automate-calendar-event-user-status branch from 8e8911b to d307b47Compare October 12, 2023 21:16

github-advanced-securityAI found potential problems Oct 12, 2023
View reviewed changes

Comment threadapps/dav/lib/CalDAV/CalendarImpl.php Fixed
Comment threadapps/dav/lib/CalDAV/CalendarImpl.php Fixed
Comment threadapps/user_status/lib/Service/StatusService.php Fixed

This comment was marked as off-topic.
Sign in to view

github-advanced-securityAI found potential problems Oct 12, 2023
View reviewed changes

Comment threadapps/dav/lib/CalDAV/CalendarImpl.php Fixed
Comment threadapps/dav/lib/CalDAV/CalendarImpl.php Fixed

github-advanced-securityAI found potential problems Oct 13, 2023
View reviewed changes

Comment threadapps/dav/lib/CalDAV/CalendarImpl.php Fixed

This comment was marked as off-topic.
Sign in to view

github-advanced-securityAI found potential problems Oct 25, 2023
View reviewed changes

Comment threadapps/dav/lib/CalDAV/Status/StatusService.php Fixed
Comment threadapps/user_status/lib/Service/StatusService.php Fixed
Comment threadapps/user_status/lib/Service/StatusService.php Fixed

skjnldsv mentioned this pull request Nov 1, 2023
chore: 28.0.0 beta 1 #41228
Merged

miaulalala mentioned this pull request Nov 6, 2023
Adjust user_status icons to a more fine- grained solution #41299
Open

blizzz mentioned this pull request Nov 6, 2023
28.0.0 beta 2 #41314
Merged

miaulalala marked this pull request as ready for review November 8, 2023 16:41

miaulalala requested review from ChristophWurst, nickvergessen and tcitworld as code owners November 8, 2023 16:41

miaulalala requested a review from st3iny November 8, 2023 16:41

ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 8, 2023

ChristophWurst reviewed Nov 8, 2023
View reviewed changes

ChristophWurst approved these changes Nov 8, 2023
View reviewed changes

miaulalala force-pushed the enh/automate-calendar-event-user-status branch from 23fbe23 to ab261fcCompare November 8, 2023 19:19

github-advanced-securityAI found potential problems Nov 8, 2023
View reviewed changes

github-advanced-securityBot found potential problems Nov 8, 2023
View reviewed changes

Comment threadapps/dav/lib/CalDAV/FreeBusy/FreeBusyGenerator.php Fixed
Comment threadapps/dav/lib/CalDAV/FreeBusy/FreeBusyGenerator.php Fixed
Comment threadapps/dav/lib/CalDAV/FreeBusy/FreeBusyGenerator.php Fixed

AndyScherzinger approved these changes Nov 9, 2023
View reviewed changes

miaulalala force-pushed the enh/automate-calendar-event-user-status branch 3 times, most recently from e358b7b to 1661393Compare November 9, 2023 11:38

nickvergessen reviewed Nov 9, 2023
View reviewed changes

Comment threadlib/composer/composer/autoload_classmap.php Outdated

miaulalala force-pushed the enh/automate-calendar-event-user-status branch from 1661393 to fc9f805Compare November 9, 2023 14:45

feat(user status): automate user status for events
f14a4f8
and automatically set a user status to free or busy depending on their calendar transparency, event status and availability settings Signed-off-by: Anna Larch <anna@nextcloud.com>

miaulalala force-pushed the enh/automate-calendar-event-user-status branch from fc9f805 to f14a4f8Compare November 9, 2023 15:20

ChristophWurst merged commit 7248d9b into masterNov 9, 2023

ChristophWurst deleted the enh/automate-calendar-event-user-status branch November 9, 2023 18:56

ChristophWurst mentioned this pull request Nov 17, 2023
[Bug]: User status automation sets status to *Away* despite activity #41548
Closed
8 tasks

section1 mentioned this pull request Sep 26, 2024
[PERFORMANCE]: IMPORTANT SQL performance issues in version 28.0.10 #48405
Closed

Uh oh!

Conversation

miaulalala commented Sep 25, 2023• edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test:

TODO

Checklist

Uh oh!

github-advanced-securityAI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

Uh oh!

Uh oh!

miaulalala commented Oct 13, 2023

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

nimishavijay commented Oct 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jancborchardt commented Oct 25, 2023

Uh oh!

nickvergessen commented Oct 25, 2023

Uh oh!

miaulalala commented Nov 6, 2023

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miaulalala commented Nov 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

miaulalala commented Sep 25, 2023•
edited by AndyScherzinger
Loading