Skip to content

Advanced search: backend allows multiples terms to search - #40618

Merged
Altahrim merged 5 commits into
masterfrom
feat/39162/advanced_search
Nov 10, 2023
Merged

Advanced search: backend allows multiples terms to search#40618
Altahrim merged 5 commits into
masterfrom
feat/39162/advanced_search

Conversation

@Altahrim

@AltahrimAltahrim commented Sep 25, 2023•
edited by ChristophWurst
Loading

Copy link
Copy Markdown
Collaborator

Ref #39162

Partly fixes#41345
Fixesnextcloud/contacts#3608

Summary

Allows API to return results of an advanced search

Checklist

@AltahrimAltahrim added the 2. developing Work in progress label Sep 25, 2023
@AltahrimAltahrim added this to the Nextcloud 28 milestone Sep 25, 2023
@AltahrimAltahrim self-assigned this Sep 25, 2023
github-advanced-security[bot]
github-advanced-securityBot found potential problems Sep 25, 2023
View reviewed changes
Comment threadcore/Controller/UnifiedSearchController.php Fixed
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch 2 times, most recently from 9852a99 to c78349bCompareSeptember 25, 2023 13:34
@AltahrimAltahrim changed the title feat(search): Allow multiple search terms in UnifiedControllerAdvanced search: backend allows multiples terms to searchSep 25, 2023
come-nc
come-nc reviewed Sep 26, 2023
View reviewed changes
Comment threadlib/public/Search/ISearchQuery.php Outdated
Comment threadlib/private/Search/SearchQuery.php Outdated
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch from e11b170 to 01ff73fCompareSeptember 28, 2023 08:45
github-advanced-security[bot]
github-advanced-securityBot found potential problems Sep 28, 2023
View reviewed changes

@github-advanced-securitygithub-advanced-securityBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch from 1756487 to c0dda46CompareSeptember 28, 2023 09:33
come-nc
come-nc reviewed Sep 28, 2023
View reviewed changes
Comment threadapps/files/lib/Search/FilesSearchProvider.php Outdated
Comment threadlib/private/Search/Filter.php Outdated
Comment threadlib/private/Search/Filter/TypeDateTime.php
Comment threadlib/private/Search/Filter/TypeFloat.php Outdated
Comment threadlib/private/Search/Filter.php Outdated
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch 3 times, most recently from 6374218 to 64e3f2cCompareOctober 6, 2023 08:51
github-advanced-security[bot]
github-advanced-securityBot found potential problems Oct 6, 2023
View reviewed changes
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadcore/Controller/UnifiedSearchController.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch from 64e3f2c to 55845d0CompareOctober 6, 2023 09:23
github-advanced-security[bot]
github-advanced-securityBot found potential problems Oct 6, 2023
View reviewed changes
Comment threadcore/Controller/UnifiedSearchController.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch from 55845d0 to df3d05fCompareOctober 10, 2023 16:12
github-advanced-security[bot]
github-advanced-securityBot found potential problems Oct 10, 2023
View reviewed changes
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch 2 times, most recently from b26220d to fa33cd8CompareOctober 17, 2023 10:42
github-advanced-security[bot]
github-advanced-securityBot found potential problems Oct 17, 2023
View reviewed changes
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadapps/files/lib/Search/FilesSearchProvider.php Fixed
Comment threadcore/Controller/UnifiedSearchController.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
Comment threadlib/private/Search/SearchComposer.php Fixed
@ChristophWurstChristophWurst mentioned this pull request Oct 17, 2023
Closed
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch from fa33cd8 to ffc108bCompareOctober 17, 2023 12:54
github-advanced-security[bot]
github-advanced-securityBot found potential problems Oct 17, 2023
View reviewed changes
Comment threadlib/private/Search/FilterFactory.php Fixed
Comment threadlib/private/Search/FilterFactory.php Fixed
Comment threadlib/private/Search/FilterFactory.php Fixed
Comment threadlib/private/Search/FilterFactory.php Fixed
Comment threadlib/private/Search/FilterFactory.php Fixed
Comment threadlib/public/Search/Filter/IntegerFilter.php Fixed
Comment threadlib/public/Search/Filter/UserFilter.php Fixed
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch from ffc108b to 1f3f5e3CompareOctober 23, 2023 14:35
@ChristophWurstChristophWurst mentioned this pull request Oct 23, 2023
Closed
@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 23, 2023
ChristophWurst
ChristophWurst reviewed Oct 23, 2023
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early feedback on the public parts

Comment threadlib/public/Search/IFilterCollection.php Outdated
Comment threadlib/public/Search/IProviderV2.php Outdated
Comment threadlib/public/Search/IProviderV2.php Outdated
Comment threadlib/public/Search/Filter/UserFilter.php
Comment threadlib/public/Search/Filter/BooleanFilter.php
github-advanced-security[bot]
github-advanced-securityBot found potential problems Nov 8, 2023
View reviewed changes
Comment threadcore/Controller/UnifiedSearchController.php Fixed
Comment threadcore/Controller/UnifiedSearchController.php Fixed
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch 3 times, most recently from 4e0cb1a to 50b397cCompareNovember 8, 2023 10:47
provokateurin
provokateurin approved these changes Nov 8, 2023
View reviewed changes

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenAPI side looks good

@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch 2 times, most recently from 3e44339 to 70e8c78CompareNovember 8, 2023 15:53
ChristophWurst
ChristophWurst approved these changes Nov 8, 2023
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For lib/public

@ChristophWurstChristophWurst mentioned this pull request Nov 8, 2023
Closed
@ChristophWurst

This comment was marked as resolved.

Sign in to view
ChristophWurst
ChristophWurst reviewed Nov 8, 2023
View reviewed changes
Comment threadlib/private/Search/SearchQuery.php
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch 7 times, most recently from 81db411 to 4accccfCompareNovember 10, 2023 08:08
@Altahrim
feat(search): Allow multiple search terms in UnifiedController
c753eef
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
chore: update openapi.json
f3181a3
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
feat(files): Allow advanced search for files
a75a93a
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
feat(caldav): Allow advanced search for events/tasks
3545a1c
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
feat(carddav): Allow advanced search for contacts
ddb8b68
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrimforce-pushed the feat/39162/advanced_search branch from 4accccf to ddb8b68CompareNovember 10, 2023 08:21
@ChristophWurst

ChristophWurst commented Nov 10, 2023

Copy link
Copy Markdown
Member

CI is done

@Altahrim
Altahrim merged commit fa761b5 into masterNov 10, 2023
@Altahrim
Altahrim deleted the feat/39162/advanced_search branch November 10, 2023 09:42
@nickvergessennickvergessen mentioned this pull request Nov 14, 2023
Open
7 tasks
@AltahrimAltahrim removed 2. developing Work in progress pending documentation This pull request needs an associated documentation update labels Mar 31, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@come-nccome-nccome-nc left review comments
@provokateurinprovokateurinprovokateurin approved these changes
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

None yet

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

🔎 Allow event date and attendee search in advanced search 🔎 Allow contact and manager search in advanced search

5 participants

@Altahrim@ChristophWurst@provokateurin@github-advanced-security@come-nc