Adding dav resource for avatars

[MorrisJobke]

• downstream of Adding dav resource for avatars owncloud/core#26872

@rullzer@mario@marinofaggiana@AndyScherzinger@tobiasKaminsky Might be interesting for you. Then you don't need private APIs anymore and can also fetch it via WebDAV ;)

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @bartv2 and @tanghus to be potential reviewers.

[codecov-io]

Codecov Report

Merging #4062 into master will increase coverage by 0.2%.
The diff coverage is 71.05%.

@@ Coverage Diff @@## master #4062 +/- ##
===========================================
+ Coverage 54.06% 54.27% +0.2% - Complexity 21274 21305 +31 
===========================================
Files 1252 1313 +61 Lines 74088 81222 +7134 Branches 0 1284 +1284 ===========================================
+ Hits 40055 44081 +4026 - Misses 34033 37141 +3108

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/Connector/Sabre/Principal.php	98.33% <ø> (-0.03%)	25 <0> (ø)
apps/dav/lib/RootCollection.php	95.65% <100%> (+0.19%)	1 <0> (ø)	⬇️
apps/dav/lib/Avatars/RootCollection.php	40% <40%> (ø)	2 <2> (?)
apps/dav/lib/Avatars/AvatarNode.php	40% <40%> (ø)	9 <9> (?)
apps/dav/lib/Avatars/AvatarHome.php	90.69% <90.69%> (ø)	20 <20> (?)
lib/private/Files/Cache/Propagator.php	94.93% <0%> (-1.27%)	16% <0%> (ø)
apps/comments/js/commentstabview.js	82.43% <0%> (ø)	0% <0%> (?)
core/js/jquery.ocdialog.js	1.57% <0%> (ø)	0% <0%> (?)
apps/systemtags/js/systemtagsinfoview.js	93.22% <0%> (ø)	0% <0%> (?)
... and 58 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0981f9a...6e537c8. Read the comment docs.

[MariusBluem]

@schiessle for federated profile pictures in sharing dialog 😁

[rullzer]

So, few things.

• WHEE!
• The extension might be problematic for clients
• I'm not really happy this loads the image resource into memory again. We should just dump the file.

Anyway. Will look into it.

[LukasReschke]

Will do some changes to satisfy coverage and CI style.

[rullzer]

I don't like this as it gets an image. Instead of just a file...

[rullzer]

Also no caching headers are set. Which would mean that if we switch over this will result in a shitload of requests to the server again

[rullzer]

Altough I'm not sure how we can set caching headers....

[LukasReschke]

Message: Call to undefined function OCA\DAV\Avatars\impagejpeg()

@rullzer 😉 – Also time to add tests to this 😝

[LukasReschke]

Altough I'm not sure how we can set caching headers....

Probably something like \OCA\DAV\CardDAV\ImageExportPlugin?

[rullzer]

Ok lets get this in and fixup the remaining stuff later.

[MorrisJobke]

Tested and works 👍