Uh oh!
There was an error while loading. Please reload this page.
fix(build): Ignore default-source.svg from image optimization - #40622
Merged
nickvergessen merged 1 commit intoSep 26, 2023
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
bigcat88
approved these changes
Sep 25, 2023
provokateurin
left a comment
Member
There was a problem hiding this comment.
I would prefer checking if the svg contains an <image/> tag to avoid this problem in other files as well. Right now this is the only file afaik, but maybe there will be more in the future
miaulalala
approved these changes
Sep 25, 2023
nickvergessen
deleted the
bugfix/40410/ignore-default-source.svg-from-optimization
branch
September 26, 2023 07:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist