Uh oh!
There was an error while loading. Please reload this page.
fix: encode uri for delete, restore and favorite - #40644
Merged
ChristophWurst merged 1 commit intoSep 29, 2023
Merged
Conversation
kesselb
commented
Sep 26, 2023
ContributorAuthor
Version for stable27: #40642 |
kesselbforce-pushed
the
fix/noid/encode-uri-trashbin-restore-files-delete-favorite
branch
2 times, most recently
from
September 26, 2023 14:58
588234c to
e5fb084ComparePytal
approved these changes
Sep 28, 2023
ChristophWurst
commented
Sep 28, 2023
Member
Conflicts mildly |
To encode # and other characters properly Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
fix/noid/encode-uri-trashbin-restore-files-delete-favorite
branch
from
September 28, 2023 18:36
e5fb084 to
4f70324Comparekesselb
enabled auto-merge
September 28, 2023 18:38
ChristophWurst
commented
Sep 29, 2023
Member
CI failure is unrelated to the code changes |
ChristophWurst
disabled auto-merge
September 29, 2023 06:28
ChristophWurst
deleted the
fix/noid/encode-uri-trashbin-restore-files-delete-favorite
branch
September 29, 2023 06:29
skjnldsv
commented
Oct 3, 2023
Member
UI is broken and show lots of encoded files now :) |
skjnldsv
commented
Oct 3, 2023
Member
Come on folks who approved, have any of you actually tested this PR ?.... |
skjnldsv
reviewed
Oct 3, 2023
| const nodeData = { | ||
| id: node.props?.fileid as number || 0, | ||
| source: generateRemoteUrl('dav' + rootPath + node.filename), | ||
| source: generateRemoteUrl(encodePath('dav' + rootPath + node.filename)), |
Member
There was a problem hiding this comment.
encodePath is no even defined here...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To encode # and other characters properly
Similar to #39842 but different ;)
#is a valid character for our filenames but also for uris in general and therefore not encoded by default.To use
#in filenames we need to encode it.TODO
Checklist