feat(database): Add replacements for deprecated fetch and fetchAll by ChristophWurst · Pull Request #40655 · nextcloud/server

ChristophWurst · 2023-09-27T12:36:20Z

Summary

DBAL deprecated these and will remove them it in the future.

TODO

Add missing methods
Delegate deprecations

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
- feat(devmanual): Add \OCP\DB\IResult::fetch deprecation documentation#11183
Backports requested where applicable (ex: critical bugfixes)

DBAL deprecated these and will remove them it in the future. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

…hAll Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

nickvergessen · 2023-09-27T12:43:47Z

+ *
+ * @since 21.0.0
+ */
+	public function fetchFirstColumn(): array;


should be mixed?

it returns the first column of all results as array<mixed>

The description is not phrased clearly about that imo, and for better consistency perhaps consider renaming the method to fetchAllFirstColumns or something like that?

nickvergessen · 2023-09-27T12:46:48Z

 * @return mixed
 *
 * @since 21.0.0
+ * @deprecated 28.0.0 use fetchAssociative, fetchNumeric or fetchOne


This will be painful :D
Touching all the queries yet again (after query() replacement)

https://getrector.com/

Also use the deprecation line from the docs here explaining the default replacement?

@ChristophWurst Out of context, but I'm just curious to know if there are any plans to introduce Rector to the project. Now that I've touched a bit of code from different parts of the code base, I think it would be a great addition to the mix if we could make everything more consistent across the code base by using an automated refactoring approach with Rector.

…hAll Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

…-result-fetch-associative-fetch-num

…hAll Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

nickvergessen · 2023-10-06T09:45:38Z

 * @return mixed
 *
 * @since 21.0.0
+ * @deprecated 28.0.0 use fetchAssociative instead of fetch(), fetchNumeric instead of fetch(\PDO::FETCH_NUM) and fetchOne instead of fetch(\PDO::FETCH_COLUMN)


Suggested change
* @deprecated 28.0.0usefetchAssociative instead of fetch(), fetchNumeric instead of fetch(\PDO::FETCH_NUM) and fetchOne instead of fetch(\PDO::FETCH_COLUMN)
* @deprecated 28.0.0usefetchAssociative instead of fetch(), fetchNumeric() instead of fetch(\PDO::FETCH_NUM) and fetchOne() instead of fetch(\PDO::FETCH_COLUMN)
🤪

and more brackets for lonely fetchAssociative!

nickvergessen · 2023-10-06T09:46:16Z

 * @return mixed[]
 *
 * @since 21.0.0
+ * @deprecated 28.0.0 use fetchAllAssociative instead of fetchAll(), fetchAllNumeric instead of fetchAll(FETCH_NUM) and fetchOne instead of fetchAll(FETCH_COLUMN)


Suggested change
* @deprecated 28.0.0usefetchAllAssociative instead of fetchAll(), fetchAllNumeric instead of fetchAll(FETCH_NUM) andfetchOne instead of fetchAll(FETCH_COLUMN)
* @deprecated 28.0.0usefetchAllAssociative instead of fetchAll(), fetchAllNumeric() instead of fetchAll(FETCH_NUM) andfetchFirstColumn() instead of fetchAll(FETCH_COLUMN)
🤪

I'm tired, boss

ChristophWurst · 2026-05-20T19:04:24Z

Superseded by #56494

feat(database): Add replacements for deprecated fetch and fetchAll
35968f2
DBAL deprecated these and will remove them it in the future. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst added the 3. to review Waiting for reviews label Sep 27, 2023

ChristophWurst requested review from blizzz, fsamapoor, juliusknorr, kesselb and nickvergessen September 27, 2023 12:36

ChristophWurst self-assigned this Sep 27, 2023

fixup! feat(database): Add replacements for deprecated fetch and fetc…
e1fb2a6
…hAll Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst added the pending documentation This pull request needs an associated documentation update label Sep 27, 2023

github-advanced-securityAI found potential problems Sep 27, 2023
View reviewed changes

Comment threadlib/private/DB/ResultAdapter.php Fixed
Comment threadlib/private/DB/ResultAdapter.php Fixed

nickvergessen requested changes Sep 27, 2023
View reviewed changes

ChristophWurst added 2 commits October 5, 2023 13:29

fixup! feat(database): Add replacements for deprecated fetch and fetc…
a6c3a7d
…hAll Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge remote-tracking branch 'origin/master' into feat/database/query…
4968328
…-result-fetch-associative-fetch-num

ChristophWurst requested a review from nickvergessen October 5, 2023 11:30

ChristophWurst mentioned this pull request Oct 5, 2023
feat(devmanual): Add \OCP\DB\IResult::fetch deprecation nextcloud/documentation#11183
Merged

nickvergessen reviewed Oct 5, 2023
View reviewed changes

Comment threadlib/public/DB/IResult.php Outdated

ChristophWurst added 2 commits October 5, 2023 18:38

fixup! feat(database): Add replacements for deprecated fetch and fetc…
d25712d
…hAll Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

fixup! feat(database): Add replacements for deprecated fetch and fetc…
c2d5024
…hAll Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

nickvergessen reviewed Oct 6, 2023
View reviewed changes

solracsf added this to the Nextcloud 28 milestone Oct 27, 2023

skjnldsv mentioned this pull request Nov 1, 2023
chore: 28.0.0 beta 1 #41228
Merged

ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 3. to review Waiting for reviews labels Nov 2, 2023

ChristophWurst marked this pull request as draft November 2, 2023 10:08

ChristophWurst removed this from the Nextcloud 28 milestone Nov 2, 2023

solracsf added this to the Nextcloud 28 milestone Nov 21, 2023

blizzz mentioned this pull request Nov 22, 2023
28.0.0 RC1 #41621
Merged
5 tasks

ChristophWurst removed this from the Nextcloud 28 milestone Nov 22, 2023

blizzz added this to the Nextcloud 29 milestone Nov 23, 2023

skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 21, 2024

This was referenced Mar 12, 2024
29.0.0 beta 2 #44152
Merged
29.0.0 beta 3 #44186
Merged
29.0.0 beta 4 #44275
Merged

Altahrim mentioned this pull request Mar 20, 2024
29.0.0 beta 5 #44361
Merged

skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024

skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024

blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025

skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025

blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026

ChristophWurst closed this May 20, 2026

ChristophWurst deleted the feat/database/query-result-fetch-associative-fetch-num branch May 20, 2026 19:04

	* @deprecated 28.0.0usefetchAssociative instead of fetch(), fetchNumeric instead of fetch(\PDO::FETCH_NUM) and fetchOne instead of fetch(\PDO::FETCH_COLUMN)
	* @deprecated 28.0.0usefetchAssociative instead of fetch(), fetchNumeric() instead of fetch(\PDO::FETCH_NUM) and fetchOne() instead of fetch(\PDO::FETCH_COLUMN)

	* @deprecated 28.0.0usefetchAllAssociative instead of fetchAll(), fetchAllNumeric instead of fetchAll(FETCH_NUM) andfetchOne instead of fetchAll(FETCH_COLUMN)
	* @deprecated 28.0.0usefetchAllAssociative instead of fetchAll(), fetchAllNumeric() instead of fetchAll(FETCH_NUM) andfetchFirstColumn() instead of fetchAll(FETCH_COLUMN)

Uh oh!

Uh oh!

Conversation

ChristophWurst commented Sep 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristophWurstOct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

🤪

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

🤪

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ChristophWurst commented Sep 27, 2023•
edited
Loading

ChristophWurstOct 5, 2023•
edited
Loading