Skip to content

Directly fix invalid values of DTEND and DTSTART - #4066

Merged
rullzer merged 1 commit into
masterfrom
always-fix-the-values-live
Mar 29, 2017
Merged

Directly fix invalid values of DTEND and DTSTART#4066
rullzer merged 1 commit into
masterfrom
always-fix-the-values-live

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

Copy link
Copy Markdown

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer to be a potential reviewer.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #4066 into master will decrease coverage by 0.01%.
The diff coverage is 59.18%.

@@ Coverage Diff @@## master #4066 +/- ##
============================================
- Coverage 54.24% 54.22% -0.02% + Complexity 21285 21283 -2 
============================================
Files 1310 1309 -1 Lines 81187 81198 +11 Branches 1284 1284 ============================================
- Hits 44036 44030 -6 - Misses 37151 37168 +17
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/Migration/CalDAVRemoveEmptyValue.php59.18% <59.18%> (ø)9 <9> (?)
apps/comments/lib/EventHandler.php79.16% <0%> (-8.34%)7% <0%> (ø)
apps/files_external/lib/Lib/Storage/SMB.php47.22% <0%> (+0.39%)112% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6853a...3bd501a. Read the comment docs.

@MorrisJobke

Copy link
Copy Markdown
Member

@nickvergessen So this is intended to be run on every upgrade? Otherwise add a version number check.

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Basically yes. It only does stuff for broken entries anyway

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And fixed some broken stuff I threw at it.

So lets do it...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@mention-bot@codecov-io@MorrisJobke@rullzer