Uh oh!
There was an error while loading. Please reload this page.
Fix small previews with Imaginary - #40670
Closed
enoch85 wants to merge 3 commits into
Closed
Conversation
enoch85
commented
Sep 28, 2023
MemberAuthor
Please backport to stable27, backport bot didn't like my efforts. |
Chartman123
approved these changes
Sep 28, 2023
Chartman123
left a comment
Contributor
There was a problem hiding this comment.
Working for me this way
solracsf
commented
Sep 28, 2023
Member
@Glandos maybe you can review here, after your last changes? |
szaimen
requested review from
a team, ArtificialOwl, icewind1991 and nfebe
and removed request for
a teamSeptember 28, 2023 09:42
Glandos
commented
Sep 29, 2023
Contributor
Given the small change involved, I think everything will be OK. However, I'm sorry to say that I don't have time right now to investigate more than that 😢 |
enoch85
commented
Sep 29, 2023
MemberAuthor
OK to merge? |
szaimen
commented
Sep 29, 2023
Contributor
maybe we should revisit this due to #38911 (comment)? |
enoch85
commented
Sep 29, 2023
MemberAuthor
Better to put that in a separate PR IMHO, this fixes the bug, then performance is another topic. But sure, it's an easy fix if the decision is to remove it. |
enoch85 added a commit
that referenced
this pull request
Sep 30, 2023
A follow up on #40670 Based on discussions here: #38911 (comment) This fixes the case were not all previews are generated, for example in the activity view: #38911 (comment) Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
5 tasks
nfebe pushed a commit
that referenced
this pull request
Oct 9, 2023
A follow up on #40670 Based on discussions here: #38911 (comment) This fixes the case were not all previews are generated, for example in the activity view: #38911 (comment) Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
zak39 pushed a commit
to zak39/server
that referenced
this pull request
Dec 19, 2023
A follow up on nextcloud#40670 Based on discussions here: nextcloud#38911 (comment) This fixes the case were not all previews are generated, for example in the activity view: nextcloud#38911 (comment) Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #38911 (comment)
Summary
Without this change PDF, TIF and some other formats aren't generated if Imaginary is used.
Checklist