Skip to content

enh(settings): Semantic user table markup - #40719

Merged
Pytal merged 6 commits into
masterfrom
enh/a11y/semantic-user-table
Oct 6, 2023
Merged

enh(settings): Semantic user table markup#40719
Pytal merged 6 commits into
masterfrom
enh/a11y/semantic-user-table

Conversation

@Pytal

@PytalPytal commented Sep 30, 2023

Copy link
Copy Markdown
Member

Summary

  • Add in-house table-friendly virtual list
  • Always keep user actions stickied to the right when toggling columns
  • Adjust tests

No visual changes

Checklist

@PytalPytal added the 2. developing Work in progress label Sep 30, 2023
@PytalPytal added this to the Nextcloud 28 milestone Sep 30, 2023
@PytalPytal self-assigned this Sep 30, 2023
@Pytal
Pytalforce-pushed the enh/a11y/semantic-user-table branch 2 times, most recently from 4f5ef26 to 53350bfCompareOctober 5, 2023 00:37
@PytalPytal changed the title Semantic user tableenh(settings): Semantic user table markupOct 5, 2023
@Pytal
Pytalforce-pushed the enh/a11y/semantic-user-table branch from 53350bf to c293ed6CompareOctober 5, 2023 00:54
@Pytal
Pytal marked this pull request as ready for review October 5, 2023 00:56

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the performances still good? Bart and I got caught with some limitations when we implemented our own, like img flickering and white spaces when scrolling fast.

@JuliaKirschenheuterJuliaKirschenheuter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge task 🤪

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the enh/a11y/semantic-user-table branch from c293ed6 to 091b3e0CompareOctober 5, 2023 23:53
@Pytal

Pytal commented Oct 6, 2023

Copy link
Copy Markdown
MemberAuthor

Are the performances still good? Bart and I got caught with some limitations when we implemented our own, like img flickering and white spaces when scrolling fast.

Not as smooth as before but lighthouse performance score is still 20/22

Performance is about the same as before in Firefox but less smooth in Chrome

@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 6, 2023
@Pytal
Pytal merged commit 649990e into masterOct 6, 2023
@Pytal
Pytal deleted the enh/a11y/semantic-user-table branch October 6, 2023 00:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilityenhancementfeature: users and groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal@JuliaKirschenheuter@artonge