Uh oh!
There was an error while loading. Please reload this page.
enh(settings): Semantic user table markup - #40719
Merged
Merged
Conversation
2 tasks
Pytalforce-pushed
the
enh/a11y/semantic-user-table
branch
2 times, most recently
from
October 5, 2023 00:37
4f5ef26 to
53350bfComparePytalforce-pushed
the
enh/a11y/semantic-user-table
branch
from
October 5, 2023 00:54
53350bf to
c293ed6ComparePytal
marked this pull request as ready for review
October 5, 2023 00:56
artonge
approved these changes
Oct 5, 2023
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Are the performances still good? Bart and I got caught with some limitations when we implemented our own, like img flickering and white spaces when scrolling fast.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
enh/a11y/semantic-user-table
branch
from
October 5, 2023 23:53
c293ed6 to
091b3e0CompareMemberAuthor
Not as smooth as before but lighthouse performance score is still 20/22 Performance is about the same as before in Firefox but less smooth in Chrome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist