Skip to content

[master] Update psalm-baseline.xml - #40725

Merged
nickvergessen merged 4 commits into
masterfrom
automated/noid/master-update-psalm-baseline
Feb 5, 2024
Merged

[master] Update psalm-baseline.xml#40725
nickvergessen merged 4 commits into
masterfrom
automated/noid/master-update-psalm-baseline

Conversation

@nextcloud-command

Copy link
Copy Markdown
Contributor

Auto-generated update psalm-baseline.xml with fixed psalm warnings

@nextcloud-command
nextcloud-command requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a teamSeptember 30, 2023 02:50
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch 3 times, most recently from 0c00854 to 85f431fCompareOctober 8, 2023 02:22
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch 2 times, most recently from e17e67d to e2c889dCompareOctober 15, 2023 02:22
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch 2 times, most recently from 15ccf1c to 8eead1aCompareOctober 22, 2023 02:22
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch 4 times, most recently from f7fdc7e to 0732a4cCompareNovember 1, 2023 02:40
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch from 0732a4c to f038819CompareNovember 5, 2023 02:20
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch 2 times, most recently from 75c69f2 to f20b304CompareNovember 16, 2023 02:22
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch 2 times, most recently from 2296d04 to dbb07dcCompareNovember 21, 2023 02:24
@solracsfsolracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch from dbb07dc to 94c4e7dCompareNovember 22, 2023 02:25
@blizzzblizzz mentioned this pull request Nov 22, 2023
5 tasks
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch from 94c4e7d to cb636b8CompareNovember 25, 2023 02:23
@come-nc

Copy link
Copy Markdown
Contributor

Rebased, updated baseline and attempted to fix baseline updating workflow.

The baseline I pushed is full of CDATA because of vimeo/psalm#10632
It should not be a problem, let’s see what CI thinks of it.

@nickvergessen

Copy link
Copy Markdown
Member

While on it, can we enforce the correct PHP version as baseline: https://github.com/nextcloud/spreed/blob/main/psalm.xml#L8
Otherwise you can use PHP 8.2 functions and psalm will not complain :P

@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch from dfc33b9 to 3543751CompareFebruary 3, 2024 02:37
@nextcloud-command
nextcloud-command requested a review from a teamFebruary 3, 2024 02:37
@nextcloud-command
nextcloud-commandforce-pushed the automated/noid/master-update-psalm-baseline branch from 3543751 to e963f37CompareFebruary 5, 2024 02:22
@nickvergessen
nickvergessen self-requested a review February 5, 2024 08:33
@come-nc
come-ncforce-pushed the automated/noid/master-update-psalm-baseline branch from e963f37 to dfc33b9CompareFebruary 5, 2024 08:44
@come-nc

Copy link
Copy Markdown
Contributor

While on it, can we enforce the correct PHP version as baseline: nextcloud/spreed@main/psalm.xml#L8 Otherwise you can use PHP 8.2 functions and psalm will not complain :P

The psalm jobs already run on 8.0, and our composer.json lists 8.0 as php platform, should be enough, no?

@come-nc
come-ncforce-pushed the automated/noid/master-update-psalm-baseline branch from dfc33b9 to 0a1fab0CompareFebruary 5, 2024 09:53
nextcloud-commandand others added 4 commits February 5, 2024 11:15
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…flow
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the automated/noid/master-update-psalm-baseline branch from 0a1fab0 to 40ab40dCompareFebruary 5, 2024 10:15
@nickvergessen
nickvergessen merged commit 35bc99d into masterFeb 5, 2024
@nickvergessen
nickvergessen deleted the automated/noid/master-update-psalm-baseline branch February 5, 2024 13:09
@come-nc

Copy link
Copy Markdown
Contributor

/backport 40ab40de30ee90ded277065da206aa3830a2f796to stable28

@come-nc

Copy link
Copy Markdown
Contributor

/backport 40ab40d to stable28

@backportbot

Copy link
Copy Markdown

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/40725/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 40ab40de
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/40725/stable28

Error: Failed to push branch backport/40725/stable28: To https://github.com/nextcloud/server.git
! [remote rejected] backport/40725/stable28 -> backport/40725/stable28 (refusing to allow a GitHub App to create or update workflow .github/workflows/update-psalm-baseline.yml without workflows permission)
error: failed to push some refs to 'https://github.com/nextcloud/server.git'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsautomated pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@nextcloud-command@come-nc@nickvergessen@blizzz@solracsf@skjnldsv