Skip to content

fix(scheduling): don't send iMIP emails to rooms / resources - #40876

Merged
miaulalala merged 1 commit into
masterfrom
fix/dont-send-imip-emails-to-rooms-resources
Nov 6, 2023
Merged

fix(scheduling): don't send iMIP emails to rooms / resources#40876
miaulalala merged 1 commit into
masterfrom
fix/dont-send-imip-emails-to-rooms-resources

Conversation

@miaulalala

@miaulalalamiaulalala commented Oct 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

The current iMIP plugin doesn't check for the CU type of the attendee and sends an invitation regardless.

Checklist

@miaulalalamiaulalala self-assigned this Oct 11, 2023
@miaulalalamiaulalala added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Oct 11, 2023
@miaulalalamiaulalala added this to the Nextcloud 28 milestone Oct 11, 2023
@miaulalala
miaulalala requested review from a team, Altahrim, icewind1991 and nfebe and removed request for a teamOctober 11, 2023 16:55
@miaulalala

miaulalala commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@miaulalala

miaulalala commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@miaulalala

miaulalala commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

github-advanced-security[bot]
github-advanced-securityAI found potential problems Oct 11, 2023
View reviewed changes
Comment threadapps/dav/lib/CalDAV/Schedule/IMipPlugin.php Fixed
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Fixed
tcitworld
tcitworld requested changes Oct 11, 2023
View reviewed changes
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Outdated
ChristophWurst
ChristophWurst reviewed Oct 12, 2023
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

Comment threadapps/dav/lib/CalDAV/Schedule/IMipPlugin.php Fixed
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Fixed
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Outdated
Comment threadapps/dav/lib/CalDAV/Schedule/IMipPlugin.php Outdated
@miaulalala

miaulalala commented Oct 12, 2023

Copy link
Copy Markdown
ContributorAuthor

Re: #40876 (comment)
The instanceof check should take care of that, no?

@miaulalalamiaulalala mentioned this pull request Oct 12, 2023
Closed
github-advanced-security[bot]
github-advanced-securityAI found potential problems Oct 12, 2023
View reviewed changes
Comment threadapps/dav/lib/CalDAV/Schedule/IMipPlugin.php Fixed
@ChristophWurst

ChristophWurst commented Oct 13, 2023

Copy link
Copy Markdown
Member

Re: #40876 (comment)
The instanceof check should take care of that, no?

You are checking the parameter object, not its value.

@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
github-advanced-security[bot]
github-advanced-securityAI found potential problems Nov 2, 2023
View reviewed changes
Comment threadapps/dav/lib/CalDAV/Schedule/IMipPlugin.php Fixed
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Fixed
@miaulalala
miaulalalaforce-pushed the fix/dont-send-imip-emails-to-rooms-resources branch 3 times, most recently from 70cb1f9 to f05e67bCompareNovember 6, 2023 15:08
@miaulalala

miaulalala commented Nov 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Failing tests are integration-sharees and interation-tags. Both ran out of time (1:00:00).

@miaulalala
fix(scheduling): don't send iMIP emails to rooms / resources
a75173a
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalalaforce-pushed the fix/dont-send-imip-emails-to-rooms-resources branch from f05e67b to a75173aCompareNovember 6, 2023 20:01
@blizzzblizzz mentioned this pull request Nov 6, 2023
Merged
@miaulalala
miaulalala merged commit 08d414b into masterNov 6, 2023
@miaulalala
miaulalala deleted the fix/dont-send-imip-emails-to-rooms-resources branch November 6, 2023 20:52
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 6, 2023
Merged
@tcitworldtcitworld mentioned this pull request Mar 28, 2024
Closed
@naveensinghnaveensingh mentioned this pull request Oct 16, 2025
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst left review comments
@blizzzblizzzblizzz approved these changes
@tcitworldtcitworldtcitworld approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 was automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim was automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe was automatically assigned from nextcloud/server-backend

Assignees

@miaulalalamiaulalala

Labels

3. to reviewWaiting for reviewsbugfeature: caldavRelated to CalDAV internals

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

6 participants

@miaulalala@ChristophWurst@blizzz@tcitworld@github-advanced-security@skjnldsv