Uh oh!
There was an error while loading. Please reload this page.
fix(session): Log critical conditions where sessions might be lost - #40878
Draft
ChristophWurst wants to merge 1 commit into
Draft
fix(session): Log critical conditions where sessions might be lost#40878ChristophWurst wants to merge 1 commit into
ChristophWurst wants to merge 1 commit into
Conversation
ChristophWurst
commented
Oct 11, 2023
MemberAuthor
/backport to stable27 |
ChristophWurstforce-pushed
the
fix/session/log-likely-lost-session-conditions
branch
from
October 11, 2023 17:57
736a5f9 to
37367ecCompareUh oh!
There was an error while loading. Please reload this page.
juliusknorr
approved these changes
Oct 11, 2023
ChristophWurstforce-pushed
the
fix/session/log-likely-lost-session-conditions
branch
from
October 12, 2023 09:48
37367ec to
44196bbCompareblizzz
approved these changes
Oct 12, 2023
blizzz
commented
Oct 12, 2023
Member
CI having opinions |
nickvergessen
approved these changes
Oct 12, 2023
* Regenerating session when cookies can't be sent -> lost * Regenerating session ID and deleting old data -> possible loss Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurstforce-pushed
the
fix/session/log-likely-lost-session-conditions
branch
from
October 12, 2023 12:11
44196bb to
95a14f2Compare| 'deleteOldSession' => $deleteOldSession, | ||
| ]); | ||
| } elseif ($deleteOldSession) { | ||
| logger('core')->warning('Calling session_regenerate_id with delete_old_session=true can lead to lost sessions'); |
MemberAuthor
There was a problem hiding this comment.
should be lowered to debug. this is called a lot
ChristophWurst
marked this pull request as draft
October 13, 2023 12:03
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://www.php.net/manual/en/function.session-regenerate-id.php
Inspiration taken from https://github.com/symfony/symfony/blob/732ef5761c6576102983c99aab4a38679adce8d2/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php#L207-L229 too.
Checklist