Skip to content

refactor: Unify running a dev server (for automated testing) - #40899

Merged
ChristophWurst merged 1 commit into
masterfrom
refactor/unify-running-dev-server
Nov 2, 2023
Merged

refactor: Unify running a dev server (for automated testing)#40899
ChristophWurst merged 1 commit into
masterfrom
refactor/unify-running-dev-server

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Oct 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Makes it quite easy to spin up a dev web server:

composer serve

It's possible to influence hostname, port and number of worker processes:

NEXTCLOUD_HOST=127.0.0.1 NEXTCLOUD_PORT=8081 NEXTCLOUD_WORKERS=10 composer serve

Ref https://github.com/php-pds/composer-script-names_research for the naming convention.

TODO

  • Add new composer script
  • Set PHP_CLI_SERVER_WORKERS and make it overridable to have a bit of concurrency

Checklist

@ChristophWurstChristophWurst added the 2. developing Work in progress label Oct 13, 2023
@ChristophWurstChristophWurst self-assigned this Oct 13, 2023
@ChristophWurst

This comment was marked as outdated.

Sign in to view
@ChristophWurst
ChristophWurstforce-pushed the refactor/unify-running-dev-server branch from 70575db to 22e669aCompareOctober 13, 2023 12:19
@solracsfsolracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 31, 2023
@ChristophWurst
ChristophWurst marked this pull request as ready for review October 31, 2023 17:03
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2023
@ChristophWurst
ChristophWurstforce-pushed the refactor/unify-running-dev-server branch from 0abdbf8 to 074827cCompareNovember 2, 2023 07:41
@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label Nov 2, 2023
Altahrim
Altahrim reviewed Nov 2, 2023
View reviewed changes
Comment threadcomposer.json Outdated
@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 2, 2023
@ChristophWurst
refactor: Unify running a dev server (for automated testing)
0da4c14
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the refactor/unify-running-dev-server branch from 88ad66c to 0da4c14CompareNovember 2, 2023 08:59
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2023
@ChristophWurst
ChristophWurst merged commit 7c66189 into masterNov 2, 2023
@ChristophWurst
ChristophWurst deleted the refactor/unify-running-dev-server branch November 2, 2023 09:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@solracsfsolracsfAwaiting requested review from solracsf

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishpending documentationThis pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst@Altahrim@skjnldsv@provokateurin@solracsf