Skip to content

optimize cache jail creation - #40995

Merged
blizzz merged 1 commit into
masterfrom
cache-jail-optimizations
Nov 3, 2023
Merged

optimize cache jail creation#40995
blizzz merged 1 commit into
masterfrom
cache-jail-optimizations

Conversation

@icewind1991

Copy link
Copy Markdown
Member
  • remove duplicate constructor assignments
  • allow the cache jail to re-use the inner cache

A modest improvement for little effort (tested with listing 2k group folders)

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added this to the Nextcloud 28 milestone Oct 19, 2023
@icewind1991
icewind1991 requested review from a team, Altahrim, ArtificialOwl and blizzz and removed request for a teamOctober 19, 2023 17:30
Comment threadlib/private/Files/Storage/Wrapper/Jail.php
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
@blizzz
blizzz merged commit 333ab4d into masterNov 3, 2023
@blizzz
blizzz deleted the cache-jail-optimizations branch November 3, 2023 16:03
@blizzzblizzz mentioned this pull request Nov 6, 2023
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@blizzz@Altahrim