Skip to content

Updated visible 'Twitter' name to 'X' in Personal info - #41041

Merged
AndyScherzinger merged 2 commits into
nextcloud:masterfrom
gcald:update-twitter-to-x-in-personal-settings
Nov 10, 2023
Merged

Updated visible 'Twitter' name to 'X' in Personal info#41041
AndyScherzinger merged 2 commits into
nextcloud:masterfrom
gcald:update-twitter-to-x-in-personal-settings

Conversation

@gcald

@gcaldgcald commented Oct 22, 2023

Copy link
Copy Markdown
Contributor

Summary

  • Updated the visual instances of 'Twitter' to 'X' in the setting's Personal Info tab

Before:

image

After:

image

TODO

  • Read through the checklist

Checklist

@gcald
gcaldforce-pushed the update-twitter-to-x-in-personal-settings branch from a595ab1 to fda0c3cCompareOctober 22, 2023 01:39
<template>
<AccountPropertySection v-bind.sync="twitter"
:placeholder="t('settings', 'Your Twitter handle')" />
:placeholder="t('settings', 'Your X handle')" />

@szaimenszaimenOct 22, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe?

Suggested change
:placeholder="t('settings', 'Your X handle')" />
:placeholder="t('settings', 'Your X
(formerly Twitter) handle')" />

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've updated the PR.

@szaimenszaimen added the 3. to review Waiting for reviews label Oct 22, 2023
@szaimenszaimen added this to the Nextcloud 28 milestone Oct 22, 2023
@szaimen
szaimen requested review from a team, artonge, nfebe and sorbaugh and removed request for a teamOctober 22, 2023 08:01
PROFILE_ENABLED: t('settings', 'Profile'),
ROLE: t('settings', 'Role'),
TWITTER: t('settings', 'Twitter'),
TWITTER: t('settings', 'X (Formerly Twitter)'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TWITTER: t('settings','X (Formerly Twitter)'),
TWITTER: t('settings','X (formerly Twitter)'),

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've updated the PR.

@gcald
gcald requested a review from szaimenOctober 22, 2023 21:55
@gcald
gcaldforce-pushed the update-twitter-to-x-in-personal-settings branch 2 times, most recently from 9a7cc39 to f0f1e49CompareOctober 28, 2023 22:38
@gcald

Copy link
Copy Markdown
ContributorAuthor

Sorry, this is my first time contributing to this project and I'm a bit confused. What are the next steps for getting this PR merged in? Also, I have a few questions:

  • Do I need to build the project and commit the /dist/ folder?

  • I saw some checks were failing in a previous commit. How can I parse these to see what tests I need to update?

    • I believe the Cypress runners failed, but I can't get these to work locally.
  • I'm having an issue getting my local version of the tests to match the results of the workflow checks.

If anyone can help answer these questions or point me in the right direction, that would be greatly appreciated. Thanks!

@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
@blizzzblizzz mentioned this pull request Nov 6, 2023
@blizzz

This comment was marked as outdated.

@blizzzblizzz mentioned this pull request Nov 10, 2023
Signed-off-by: George Calderon <gcald117@gmail.com>
Signed-off-by: George Calderon <gcald117@gmail.com>
@AndyScherzinger
AndyScherzingerforce-pushed the update-twitter-to-x-in-personal-settings branch from f0f1e49 to a047686CompareNovember 10, 2023 16:43
@AndyScherzinger

Copy link
Copy Markdown
Member

/compile /

@AndyScherzinger
AndyScherzinger merged commit a047686 into nextcloud:masterNov 10, 2023
@welcome

welcomeBot commented Nov 10, 2023

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyScherzinger

Copy link
Copy Markdown
Member

Merged via #41385

Thanks a lot for the PR @gcald

To answer your questions

  • Do I need to build the project and commit the /dist/ folder?

Yes the dist folder needs to be commited

  • I saw some checks were failing in a previous commit. How can I parse these to see what tests I need to update?
  • I believe the Cypress runners failed, but I can't get these to work locally.

Test failures were not related to your PR, you can view the output at the bottom of PRs on the "Details" link of the failing Github action.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@gcald@blizzz@AndyScherzinger@artonge@nfebe@szaimen