Skip to content

optimize builtin storage wrappers - #41119

Merged
icewind1991 merged 2 commits into
masterfrom
optmize-storage-wrappers
Nov 8, 2023
Merged

optimize builtin storage wrappers#41119
icewind1991 merged 2 commits into
masterfrom
optmize-storage-wrappers

Conversation

@icewind1991

@icewind1991icewind1991 commented Oct 25, 2023

Copy link
Copy Markdown
Member

Mostly replacing $storage->instanceOfStorage with $mount instance which is significantly faster

@solracsfsolracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@icewind1991
icewind1991force-pushed the optmize-storage-wrappers branch 3 times, most recently from 670c390 to 20ea66aCompareOctober 30, 2023 17:43
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
@icewind1991
icewind1991force-pushed the optmize-storage-wrappers branch from 20ea66a to fe8cfe4CompareNovember 1, 2023 13:17
@icewind1991
icewind1991 marked this pull request as ready for review November 2, 2023 13:21
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Nov 2, 2023
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, come-nc, nfebe and sorbaugh and removed request for a teamNovember 2, 2023 13:21
come-nc
come-nc approved these changes Nov 6, 2023
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks sane.

@blizzzblizzz mentioned this pull request Nov 6, 2023
Merged
@icewind1991
optimize builtin storage wrappers
dec880b
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 mentioned this pull request Nov 8, 2023
Closed
@icewind1991
icewind1991force-pushed the optmize-storage-wrappers branch from fe8cfe4 to 11ee868CompareNovember 8, 2023 14:31
@icewind1991

icewind1991 commented Nov 8, 2023

Copy link
Copy Markdown
MemberAuthor

merged #41056 into this due to the code overlap

@icewind1991
optimize isShared and isMounted
f4fa2fb
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the optmize-storage-wrappers branch from 11ee868 to f4fa2fbCompareNovember 8, 2023 16:35
@icewind1991
icewind1991 merged commit b29bc59 into masterNov 8, 2023
@icewind1991
icewind1991 deleted the optmize-storage-wrappers branch November 8, 2023 21:14
@icewind1991

icewind1991 commented Nov 8, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@icewind1991

icewind1991 commented Nov 8, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@AndyScherzinger

AndyScherzinger commented Nov 9, 2023

Copy link
Copy Markdown
Member

/backport to stable27

@AndyScherzinger

AndyScherzinger commented Nov 9, 2023

Copy link
Copy Markdown
Member

stable 26 has conflicts with the commits applied

@AndyScherzinger

AndyScherzinger commented Nov 9, 2023

Copy link
Copy Markdown
Member

stable 27 has conflicts with the commits applied

@icewind1991icewind1991 mentioned this pull request Nov 9, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@AndyScherzinger@come-nc@solracsf@skjnldsv