Skip to content

Add OpenAPI attribute to allow multiple scopes - #41175

Merged
nickvergessen merged 1 commit into
masterfrom
feat/noid/openapi-scopes
Nov 7, 2023
Merged

Add OpenAPI attribute to allow multiple scopes#41175
nickvergessen merged 1 commit into
masterfrom
feat/noid/openapi-scopes

Conversation

@nickvergessen

@nickvergessennickvergessen commented Oct 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

🚧 Todo

  • Add OpenAPIattribute
  • Fix the extractor to handle the new attribute
  • Deprecate IgnoreOpenAPI attribute
  • Replace existing IgnoreOpenAPI attributes

Checklist

@nickvergessennickvergessen added the 2. developing Work in progress label Oct 28, 2023
@nickvergessennickvergessen added this to the Nextcloud 28 milestone Oct 28, 2023
@nickvergessennickvergessen self-assigned this Oct 28, 2023
@nickvergessen
nickvergessen marked this pull request as draft October 28, 2023 13:59
@nickvergessennickvergessen mentioned this pull request Oct 28, 2023
Merged
5 tasks
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
@nickvergessen
nickvergessenforce-pushed the feat/noid/openapi-scopes branch from 8cae45c to 99e5f79CompareNovember 3, 2023 08:13
@nickvergessennickvergessen added 3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update and removed 2. developing Work in progress labels Nov 3, 2023
@nickvergessen
nickvergessen marked this pull request as ready for review November 3, 2023 08:14
provokateurin
provokateurin requested changes Nov 3, 2023
View reviewed changes
Comment threadlib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated
Comment threadlib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated
Comment threadlib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated
Comment threadlib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated
Comment threadlib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated
Comment threadlib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated
@nickvergessen
feat(openapi): Add OpenAPI attribute to allow multiple scopes and ove…
ffc1bb7
…rwriting tags
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the feat/noid/openapi-scopes branch from 99e5f79 to ffc1bb7CompareNovember 3, 2023 08:25
@blizzzblizzz mentioned this pull request Nov 6, 2023
Merged
@nickvergessen
nickvergessen merged commit a77af05 into masterNov 7, 2023
@nickvergessen
nickvergessen deleted the feat/noid/openapi-scopes branch November 7, 2023 07:39
@nickvergessennickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigcat88bigcat88bigcat88 approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@andrey18106andrey18106andrey18106 approved these changes
@marcelklehrmarcelklehrAwaiting requested review from marcelklehr
@julien-ncjulien-ncAwaiting requested review from julien-nc

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@bigcat88@provokateurin@andrey18106