Uh oh!
There was an error while loading. Please reload this page.
fix(dav): multiple fixes in usage of webdav library - #41202
Merged
Conversation
pulsejet
commented
Oct 30, 2023
Member
- Refresh token on update
- Fix some very weird imports
- Patch fetch instead of request to prevent accessing impl details
pulsejet
commented
Oct 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
pulsejet added a commit
to pulsejet/nextcloud-files
that referenced
this pull request
Oct 30, 2023
nextcloud/server#41202 Signed-off-by: Varun Patil <varunpatil@ucla.edu>
skjnldsv
commented
Oct 31, 2023
Member
Can you clarify what is this about? :) |
pulsejet added a commit
to pulsejet/nextcloud-files
that referenced
this pull request
Oct 31, 2023
nextcloud/server#41202 Signed-off-by: Varun Patil <varunpatil@ucla.edu>
pulsejet added a commit
to pulsejet/nextcloud-files
that referenced
this pull request
Oct 31, 2023
nextcloud/server#41202 Signed-off-by: Varun Patil <varunpatil@ucla.edu>
pulsejetforce-pushed
the
pulsejet/fix-webdav
branch
2 times, most recently
from
October 31, 2023 17:58
3a50a40 to
59c544cComparepulsejet
commented
Oct 31, 2023
MemberAuthor
To patch import{request}from'webdav/dist/node/request.js'This is an implementation detail of the webdav library and also needs the node polyfills. Instead we can just patch BTW, fixed the style to align with nextcloud-files |
Merged
artonge
approved these changes
Nov 2, 2023
skjnldsv
approved these changes
Nov 3, 2023
MemberAuthor
I want to point out that things might be broken without this patch in 28. When the refresh token changes, the WebDAV clients are never updated in RC.1 This is not a feature, it's a fix to a regression. |
pulsejetforce-pushed
the
pulsejet/fix-webdav
branch
from
November 27, 2023 18:27
59c544c to
3422780Comparepulsejetforce-pushed
the
pulsejet/fix-webdav
branch
from
November 28, 2023 19:38
3422780 to
0b0ea51Comparepulsejet
commented
Nov 28, 2023
MemberAuthor
/compile amend / |
pulsejet
enabled auto-merge
November 28, 2023 19:39
pulsejetforce-pushed
the
pulsejet/fix-webdav
branch
4 times, most recently
from
November 28, 2023 21:08
a8cde62 to
410bdddComparepulsejet
commented
Nov 28, 2023
MemberAuthor
CI failure seems unrelated |
skjnldsv
disabled auto-merge
February 28, 2024 18:22
1. Refresh token on update 2. Fix some very weird imports 3. Patch fetch instead of request to prevent accessing impl details Signed-off-by: Varun Patil <varunpatil@ucla.edu>
skjnldsvforce-pushed
the
pulsejet/fix-webdav
branch
from
February 28, 2024 18:26
410bddd to
b03fd6eCompare Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.