Skip to content

[stable26] Show proper warning on 0 quota - #41264

Merged
blizzz merged 2 commits into
stable26from
bugfix/noid/quota-0
Nov 15, 2023
Merged

[stable26] Show proper warning on 0 quota#41264
blizzz merged 2 commits into
stable26from
bugfix/noid/quota-0

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Nov 3, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Steps to reproduce

  • Have 0 quota configured
  • Open the file list

before

The file create menu was shown

After

A proper info is shown as it was on Nextcloud 25

Screenshot 2023-11-03 at 11 57 28

max-nextcloudand others added 2 commits November 3, 2023 11:17
@max-nextcloud@juliusknorr
fix(files): url used to retrive storage stats
a4d7ae6
Signed-off-by: Max <max@nextcloud.com>
@juliusknorr
fix: Apply directory permissions for new api response
f63fa8c
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr changed the title bugfix/noid/quota 0[stable26] Show proper warning on 0 quotaNov 3, 2023
@juliusknorr
juliusknorr requested review from a team, nfebe, skjnldsv and sorbaugh and removed request for a teamNovember 3, 2023 10:58
@juliusknorrjuliusknorr added the 3. to review Waiting for reviews label Nov 3, 2023
juliusknorr
juliusknorr commented Nov 3, 2023
View reviewed changes
Comment threadapps/files/js/files.js
@juliusknorr

juliusknorr commented Nov 3, 2023

Copy link
Copy Markdown
MemberAuthor

f63fa8c would be worth to be ported to 27 as well

@solracsf

solracsf commented Nov 3, 2023

Copy link
Copy Markdown
Member

Why the message is not You don't have either permission or quota to upload or create files here ?

@juliusknorr

juliusknorr commented Nov 6, 2023

Copy link
Copy Markdown
MemberAuthor

Something to discuss separately in an issue I'd say since we would want to change this in the master branch first anyways.

@solracsfsolracsf added this to the Nextcloud 26.0.9 milestone Nov 10, 2023
@blizzzblizzz mentioned this pull request Nov 13, 2023
Merged
kesselb
kesselb approved these changes Nov 14, 2023
View reviewed changes

@kesselbkesselb left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@blizzz
blizzz merged commit a6997c8 into stable26Nov 15, 2023
@blizzz
blizzz deleted the bugfix/noid/quota-0 branch November 15, 2023 20:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@kesselbkesselbkesselb approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@nfebenfebeAwaiting requested review from nfebenfebe was automatically assigned from nextcloud/server-frontend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh was automatically assigned from nextcloud/server-frontend
@susnuxsusnuxAwaiting requested review from susnux
@datenangebotdatenangebotAwaiting requested review from datenangebot

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 26.0.9

Development

Successfully merging this pull request may close these issues.

6 participants

@juliusknorr@solracsf@blizzz@kesselb@skjnldsv@max-nextcloud