Skip to content

Customize rendering for live photos - #41308

Merged
artonge merged 3 commits into
masterfrom
artonge/feat/live_photos
Nov 9, 2023
Merged

Customize rendering for live photos#41308
artonge merged 3 commits into
masterfrom
artonge/feat/live_photos

Conversation

@artonge

@artongeartonge commented Nov 6, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Hide .mov file when it has a hidden=true property.
  • Show a play icon on .png file when it has a live-photo metadata.

Visuals

Screenshot from 2023-11-09 10-48-48
Screenshot from 2023-11-09 10-48-40

@artongeartonge added this to the Nextcloud 28 milestone Nov 6, 2023
@artongeartonge self-assigned this Nov 6, 2023
@artonge
artongeforce-pushed the artonge/feat/metadata/port_providers branch 2 times, most recently from e5333dc to 404d251CompareNovember 6, 2023 15:10
@artonge
artongeforce-pushed the artonge/feat/live_photos branch 2 times, most recently from f1bdf07 to 5da3604CompareNovember 6, 2023 15:14
@artongeartonge changed the title Support live photosCustomize rendering for live photosNov 6, 2023
@blizzzblizzz mentioned this pull request Nov 6, 2023
Merged
@artonge
artongeforce-pushed the artonge/feat/metadata/port_providers branch 2 times, most recently from 0f7e67f to bfc40a1CompareNovember 8, 2023 10:02
@artonge
artongeforce-pushed the artonge/feat/live_photos branch from 078f8a8 to fcc8b7bCompareNovember 8, 2023 10:14
@artonge
artongeforce-pushed the artonge/feat/metadata/port_providers branch 8 times, most recently from 2447b62 to 015b3c4CompareNovember 8, 2023 13:46
@artonge
artongeforce-pushed the artonge/feat/live_photos branch 4 times, most recently from bd7e918 to 87b86b8CompareNovember 8, 2023 15:06
@artonge
artonge marked this pull request as ready for review November 8, 2023 15:06
@artonge
artongeforce-pushed the artonge/feat/metadata/port_providers branch from 015b3c4 to d3a313fCompareNovember 8, 2023 15:24
@artonge
artongeforce-pushed the artonge/feat/live_photos branch from 232f874 to 63791e9CompareNovember 8, 2023 15:28
@skjnldsv

skjnldsv commented Nov 8, 2023

Copy link
Copy Markdown
Member

We should probably improve the contrast of the overlay icon like for the star icon

Do it with css

skjnldsv
skjnldsv previously requested changes Nov 8, 2023
View reviewed changes
Comment threadapps/files/src/views/FilesList.vue Outdated
Comment threadapps/files/src/init.ts
Base automatically changed from artonge/feat/metadata/port_providers to masterNovember 8, 2023 16:58
ArtificialOwl
ArtificialOwl approved these changes Nov 9, 2023
View reviewed changes

@ArtificialOwlArtificialOwl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back-end part is 👍

@artonge
artonge requested a review from skjnldsvNovember 9, 2023 09:49
@artonge
artongeforce-pushed the artonge/feat/live_photos branch 3 times, most recently from b5bf80e to 80a79acCompareNovember 9, 2023 10:56
@artonge
artonge enabled auto-merge November 9, 2023 11:49
susnux
susnux approved these changes Nov 9, 2023
View reviewed changes

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

Comment threadapps/dav/lib/Connector/Sabre/FilesPlugin.php
Comment threadapps/files/src/components/FileEntry/FileEntryPreview.vue
Comment threadapps/files/src/components/FileEntry/FileEntryPreview.vue
Comment threadapps/files/src/views/FilesList.vue
@artongeartonge added the pending documentation This pull request needs an associated documentation update label Nov 9, 2023
@artonge

artonge commented Nov 9, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Cypress failure unrelated

@artonge
artongeforce-pushed the artonge/feat/live_photos branch from 80a79ac to a320075CompareNovember 9, 2023 13:37
@artonge
artongeforce-pushed the artonge/feat/live_photos branch from a320075 to 4840e3eCompareNovember 9, 2023 16:15
@artonge
Hide .mov for live photos
1c84139
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Display play icon over live photos' previews
b180ca9
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Compile assets
dc00904
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
artongeforce-pushed the artonge/feat/live_photos branch from 4840e3e to dc00904CompareNovember 9, 2023 21:46
@artonge

artonge commented Nov 9, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI failure unrelated

@artonge
artonge disabled auto-merge November 9, 2023 22:53
@artonge
artonge merged commit 1fe951f into masterNov 9, 2023
@artonge
artonge deleted the artonge/feat/live_photos branch November 9, 2023 22:53
@artongeartonge mentioned this pull request Nov 13, 2023
Closed
29 tasks
@kesselbkesselb mentioned this pull request Nov 14, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwlArtificialOwlArtificialOwl approved these changes
@susnuxsusnuxsusnux approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner

Assignees

@artongeartonge

Labels

3. to reviewWaiting for reviewsenhancementfeature: filesjavascriptpending documentationThis pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge@skjnldsv@ArtificialOwl@susnux