Uh oh!
There was an error while loading. Please reload this page.
enh(systemtags): Add accessible system tags form - #41335
Merged
Merged
Conversation
Merged
JuliaKirschenheuter
commented
Nov 8, 2023
Contributor
😱 would need time to review |
ShGKme
approved these changes
Nov 8, 2023
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Works fine.
But from a11y perspective, I'm not sure that this is clear when this form is at the same time create and edit form, especially when searching a tag to edit is a part of the form.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Pytalforce-pushed
the
enh/a11y/admin-collab-tags
branch
from
November 9, 2023 00:33
4b2e938 to
3516f93Comparesusnux
approved these changes
Nov 9, 2023
JuliaKirschenheuter
approved these changes
Nov 9, 2023
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
enh/a11y/admin-collab-tags
branch
4 times, most recently
from
November 16, 2023 02:30
f670fa6 to
ca35ea7CompareSigned-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
enh/a11y/admin-collab-tags
branch
from
November 16, 2023 02:34
ca35ea7 to
470f825Compare
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To Do
Checklist