Uh oh!
There was an error while loading. Please reload this page.
Metadata must be set a editable for PROPPATCH - #41390
Merged
Merged
Conversation
| * Disable modification of the displayname property for files and | ||
| * folders via PROPPATCH. See PROPFIND for more information. | ||
| */ | ||
| $propPatch->handle(self::DISPLAYNAME_PROPERTYNAME, function ($displayName) { |
Check notice
Code scanning / Psalm
MissingClosureParamType
Uh oh!
There was an error while loading. Please reload this page.
ArtificialOwlforce-pushed
the
enh/noid/limit-proppatch-metadata
branch
from
November 11, 2023 11:56
8235cdc to
9cac531CompareUh oh!
There was an error while loading. Please reload this page.
ArtificialOwlforce-pushed
the
enh/noid/limit-proppatch-metadata
branch
from
November 11, 2023 12:10
9cac531 to
76b44a5CompareUh oh!
There was an error while loading. Please reload this page.
ArtificialOwl
commented
Nov 11, 2023
MemberAuthor
cypress error not related |
Merged
ArtificialOwlforce-pushed
the
enh/noid/limit-proppatch-metadata
branch
2 times, most recently
from
November 13, 2023 17:09
1ebc2e1 to
e25ebe6CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ArtificialOwlforce-pushed
the
enh/noid/limit-proppatch-metadata
branch
2 times, most recently
from
November 13, 2023 17:38
11395c9 to
8e4f8e9CompareArtificialOwl
commented
Nov 13, 2023
MemberAuthor
cypress error does not seems related |
ArtificialOwlforce-pushed
the
enh/noid/limit-proppatch-metadata
branch
3 times, most recently
from
November 14, 2023 08:12
edd8494 to
b9f5552Compareartonge
reviewed
Nov 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
artonge
approved these changes
Nov 14, 2023
ArtificialOwlforce-pushed
the
enh/noid/limit-proppatch-metadata
branch
2 times, most recently
from
November 14, 2023 11:01
61a26fc to
a460d61CompareSigned-off-by: Maxence Lange <maxence@artificial-owl.com>
blizzzforce-pushed
the
enh/noid/limit-proppatch-metadata
branch
from
November 14, 2023 13:38
a460d61 to
847c687Comparecome-nc
approved these changes
Nov 14, 2023
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Small improvements needed on phpdoc for the EDIT_* enum
| * @param string $key metadata key | ||
| * | ||
| * @inheritDoc | ||
| * @return int edit permission |
Contributor
There was a problem hiding this comment.
Suggested change
| * @return int edit permission | |
| * @return IMetadataValueWrapper::EDIT_* edit permission level |
| * @param string $key metadata key | ||
| * @param string $type metadata type | ||
| * @param bool $indexed TRUE if metadata can be search | ||
| * @param int $editPermission remote edit permission via Webdav PROPPATCH |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param int$editPermission remote edit permission via Webdav PROPPATCH | |
| * @param IMetadataValueWrapper::EDIT_*$editPermission remote edit permission level via Webdav PROPPATCH |
| * (Webdav PROPPATCH) | ||
| * | ||
| * @param string $key metadata key | ||
| * @param int $permission remote edit permission |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param int$permission remote edit permission | |
| * @param IMetadataValueWrapper::EDIT_*$permission remote edit permission level |
| * | ||
| * @param string $key metadata key | ||
| * | ||
| * @return int |
Contributor
There was a problem hiding this comment.
Suggested change
| * @return int | |
| * @return IMetadataValueWrapper::EDIT_* edit permission level |
| * set remote edit permission | ||
| * (Webdav PROPPATCH) | ||
| * | ||
| * @param int $permission edit permission |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param int$permission edit permission | |
| * @param IMetadataValueWrapper::EDIT_*$permission edit permission level |
| * get remote edit permission | ||
| * (Webdav PROPPATCH) | ||
| * | ||
| * @return int edit permission |
Contributor
There was a problem hiding this comment.
Suggested change
| * @return int edit permission | |
| * @return IMetadataValueWrapper::EDIT_* edit permission level |
MemberAuthor
There was a problem hiding this comment.
let me do this on a separated PR, post merge
AndyScherzinger
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the implementation of metadata and its compatibility with webdav PROPPATCH request, and to avoid unexpected behavior, 2 things needs to be implemented:
throws exception on fail, might be better to just log a warning but keep the process running ?