Skip to content

fix(log): Log exception class when message is empty - #41406

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/log-exception-class-when-message-is-empty
Nov 13, 2023
Merged

fix(log): Log exception class when message is empty#41406
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/log-exception-class-when-message-is-empty

Conversation

@nickvergessen

@nickvergessennickvergessen commented Nov 13, 2023

Copy link
Copy Markdown
Member
  • Resolves:
  • Before is first line
  • After is last line

grafik

Checklist

@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Nov 13, 2023
@nickvergessennickvergessen added this to the Nextcloud 28 milestone Nov 13, 2023
@nickvergessennickvergessen self-assigned this Nov 13, 2023
@nickvergessen
nickvergessen requested review from ArtificialOwl, nfebe and sorbaugh and removed request for a teamNovember 13, 2023 08:50
tcitworld
tcitworld approved these changes Nov 13, 2023
View reviewed changes

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an "Exception thrown:" prefix for context?

@blizzzblizzz mentioned this pull request Nov 13, 2023
Merged
ChristophWurst
ChristophWurst approved these changes Nov 13, 2023
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also find out where an empty log message is logged?

@nickvergessen

nickvergessen commented Nov 13, 2023

Copy link
Copy Markdown
MemberAuthor

Can we also find out where an empty log message is logged?

The error from production was in logged via this:

server/index.php

Line 81 in bb2c2bb

\OC::$server->get(LoggerInterface::class)->error($ex->getMessage(), [

@nickvergessen
fix(log): Log exception class when message is empty
a5684ea
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/log-exception-class-when-message-is-empty branch from 78915b9 to a5684eaCompareNovember 13, 2023 11:45
@nickvergessen

nickvergessen commented Nov 13, 2023

Copy link
Copy Markdown
MemberAuthor

Added the prefix

@nickvergessen
nickvergessen merged commit 073ec6d into masterNov 13, 2023
@nickvergessen
nickvergessen deleted the bugfix/noid/log-exception-class-when-message-is-empty branch November 13, 2023 13:28
@nickvergessen

nickvergessen commented Nov 13, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@nickvergessen

nickvergessen commented Nov 13, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 13, 2023
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 13, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@tcitworldtcitworldtcitworld approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@ChristophWurst@tcitworld