Skip to content

don't show shares from disabled users - #41437

Closed
icewind1991 wants to merge 1 commit into
masterfrom
share-hide-disabled
Closed

don't show shares from disabled users#41437
icewind1991 wants to merge 1 commit into
masterfrom
share-hide-disabled

Conversation

@icewind1991

@icewind1991icewind1991 commented Nov 13, 2023

Copy link
Copy Markdown
Member

This makes it so shares owned by disabled users no longer show up.

  • Is the behavior change desired, these shares currently mostly work?
  • Is there a way to reduce the performance overhead of checking the user availability?

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Nov 13, 2023
@icewind1991icewind1991 added this to the Nextcloud 28 milestone Nov 13, 2023
@icewind1991
icewind1991 requested review from a team, Altahrim, nfebe and sorbaugh and removed request for a teamNovember 13, 2023 15:51
@come-nc

Copy link
Copy Markdown
Contributor

See #39699 , hiding shares by disabled users was supposed to be an option in 28, not a default.

@blizzzblizzz mentioned this pull request Nov 14, 2023
@skjnldsv
skjnldsv deleted the share-hide-disabled branch March 14, 2024 07:52
@skjnldsvskjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@come-nc@skjnldsv