Added option to disable Edit Locally menu option

[Koc]

Summary

Many of our users has no installed software for edit file locally. This leads to struggling with mentioned menu option. For me this option also does nothing for any file format. So as an option - we can add a way to disable it completely.

by default:

with option

# config/config.php<?php$CONFIG = array (
// ...'disable_edit_locally' => true,
);

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Koc]

Test failures looks unrelated

[Koc]

@blizzz@solracsf@AndyScherzinger hey mates, any chance to review this small PR? 🙏

[solracsf]

config.php option should also be documented.

[Pytal]

We should move away from PHP template params and use provideInitialState on backend + loadState from @nextcloud/initial-state on frontend

[Koc]

@solracsf good catch, added notes in config.sample.php

@Pytal oh, I wasnt aware about that but I like it more than jQuery val() 😄 . Fixed + manually re-tested

[jancborchardt]

Rather than having a switch to disable this altogether, wouldn’t the proper approach here be that the desktop client communicates if a relevant desktop app can be handled? And if the desktop client is not available or installed for the account, then we can disable the entry too (not sure if we already do this).

@tobiasKaminsky@mgallien is this possible?

I understand this is probably more complicated to code, but then there is 0 additional configuration.

[jancborchardt]

For me this option also does nothing for any file format.

@Koc not even for file formats where you have a handler installed, and you have the Nextcloud desktop client installed? This is a real issue we should fix then for everyone. Simply allowing some people to disable the feature altogether does not fix the original issue unfortunately. :)

[mgallien]

Rather than having a switch to disable this altogether, wouldn’t the proper approach here be that the desktop client communicates if a relevant desktop app can be handled? And if the desktop client is not available or installed for the account, then we can disable the entry too (not sure if we already do this).

@tobiasKaminsky@mgallien is this possible?

I understand this is probably more complicated to code, but then there is 0 additional configuration.

technically would require (as far as I understand) to have an extension in your browser (like KeePassXC integration or plasma desktop integration) that would be able to communicate with the desktop client (or other software) and check for their presence
feasible and we would know what to do but still a significant effort

[jancborchardt]

@mgallien ok, no, requiring a browser extension would not be feasible. I thought we could know whether the browser currently in use and the desktop client are on the same system for example, as they are connected by the server.

Then @sorbaugh@AndyScherzinger cc regarding that off-switch for this feature, seems fine if it is only a config.php setting?