Uh oh!
There was an error while loading. Please reload this page.
Fix adding x-requested-with header for relative URLs in some cases - #41632
Merged
Conversation
julien-nc
requested review from
a team, emoral435, juliusknorr, skjnldsv and susnux
and removed request for
a teamNovember 21, 2023 10:05
julien-nc
enabled auto-merge
November 21, 2023 10:06
julien-ncforce-pushed
the
fix/relative-url-x-requested-with
branch
from
November 21, 2023 10:09
0e18a47 to
6b3e70cComparejuliusknorr
approved these changes
Nov 23, 2023
julien-ncforce-pushed
the
fix/relative-url-x-requested-with
branch
2 times, most recently
from
November 24, 2023 09:19
aeac884 to
323b6f7Comparejulien-nc
commented
Nov 24, 2023
MemberAuthor
/backport to stable28 |
julien-nc
commented
Nov 24, 2023
MemberAuthor
@juliushaertl@emoral435@susnux Cypress test failure seems unrelated (theming app). Can someone force merge this? 🙏 |
… URL is empty Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
susnuxforce-pushed
the
fix/relative-url-x-requested-with
branch
from
November 24, 2023 10:33
8729f37 to
5d5572cComparejulien-nc
commented
Nov 27, 2023
MemberAuthor
/backport to stable27 |
julien-nc
commented
Nov 27, 2023
MemberAuthor
/backport to stable26 |
julien-nc
commented
Nov 27, 2023
MemberAuthor
/backport to stable25 |
skjnldsv
commented
Jan 15, 2024
Member
/skjnldsv-backport to stable27 |
skjnldsv
commented
Jan 15, 2024
Member
/skjnldsv-backport to stable26 |
This was referenced Jan 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When NC is at the root path of the web server,
getRootUrl()returns an empty string andisNextcloudUrl()always returned true for relative URLs.The condition to know if a URL points to NC is now:
This broke the OpenStreetMap integration in instances that are accessible at the root of the webserver.