Skip to content

feat(search): hide search provider from list - #41646

Merged
Altahrim merged 2 commits into
masterfrom
feat/hide-search-provider
Nov 22, 2023
Merged

feat(search): hide search provider from list#41646
Altahrim merged 2 commits into
masterfrom
feat/hide-search-provider

Conversation

@Altahrim

@AltahrimAltahrim commented Nov 21, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

@AltahrimAltahrim added the 3. to review Waiting for reviews label Nov 21, 2023
@Altahrim
Altahrim requested review from a team and nickvergessenNovember 21, 2023 17:17
@AltahrimAltahrim self-assigned this Nov 21, 2023
@Altahrim
Altahrim requested review from ArtificialOwl, nfebe and sorbaugh and removed request for a teamNovember 21, 2023 17:17
@AltahrimAltahrim mentioned this pull request Nov 21, 2023
Closed
nfebe
nfebe reviewed Nov 21, 2023
View reviewed changes
Comment threadapps/settings/lib/Search/UserSearch.php
nfebe
nfebe approved these changes Nov 21, 2023
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one in-line worry, this works.

nickvergessen
nickvergessen reviewed Nov 21, 2023
View reviewed changes
Comment threadlib/public/Search/IProvider.php Outdated
Comment threadlib/public/Search/IProvider.php
@solracsfsolracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@Altahrim
Altahrimforce-pushed the feat/hide-search-provider branch from e328a87 to bf3a68fCompareNovember 22, 2023 07:35
@Altahrim
feat(search): hide search provider
75e5854
Some search providers can be hidden if they send `null` in `getOrder`
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
feat(search): hide user search if not on user list
0d8aa68
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrimforce-pushed the feat/hide-search-provider branch from bf3a68f to 0d8aa68CompareNovember 22, 2023 07:48
@Altahrim
Altahrim merged commit ba1af2b into masterNov 22, 2023
@Altahrim
Altahrim deleted the feat/hide-search-provider branch November 22, 2023 08:49
@blizzzblizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Nov 30, 2023
@nickvergessen
fix(search): Hide "Messages in current conversation" when not on talk
f2fddb6
Possible since nextcloud/server#41646
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen mentioned this pull request Nov 30, 2023
Merged
3 tasks
backportbot-nextcloudBot pushed a commit to nextcloud/spreed that referenced this pull request Nov 30, 2023
@nickvergessen@backportbot-nextcloud
fix(search): Hide "Messages in current conversation" when not on talk
75eab61
Possible since nextcloud/server#41646
Signed-off-by: Joas Schilling <coding@schilljs.com>
@joshtrichardsjoshtrichards mentioned this pull request Jul 31, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@artongeartongeartonge approved these changes
@nfebenfebenfebe approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@Altahrim@nickvergessen@artonge@nfebe@solracsf