Skip to content

UI updates for global search - #41781

Merged
AndyScherzinger merged 3 commits into
masterfrom
minor-ui-updates-global-search
Nov 29, 2023
Merged

UI updates for global search#41781
AndyScherzinger merged 3 commits into
masterfrom
minor-ui-updates-global-search

Conversation

@nfebe

@nfebenfebe commented Nov 27, 2023

Copy link
Copy Markdown
Contributor
  • Use standard font of filter tags/chips
  • No bold
  • Use close icon and no close thick

#41651

@nfebenfebe changed the title Improve accesibility for search tags/chipsUI updates for global searchNov 27, 2023
@nfebe
nfebeforce-pushed the minor-ui-updates-global-search branch from 1f27342 to d886b51CompareNovember 27, 2023 22:40
@nfebe

Copy link
Copy Markdown
ContributorAuthor
BeforeAfter
Screenshot from 2023-11-27 23-46-54Screenshot from 2023-11-27 23-44-55
Screenshot from 2023-11-27 23-47-16Screenshot from 2023-11-27 23-45-09

@nimishavijay

@nfebe
nfebeforce-pushed the minor-ui-updates-global-search branch from d886b51 to 2199f82CompareNovember 28, 2023 14:27
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the minor-ui-updates-global-search branch from 2199f82 to 96c945dCompareNovember 28, 2023 15:03
@AndyScherzingerAndyScherzinger added this to the Nextcloud 29 milestone Nov 28, 2023
@nfebe
nfebeforce-pushed the minor-ui-updates-global-search branch 2 times, most recently from 743d76a to 4944c60CompareNovember 28, 2023 16:08
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the minor-ui-updates-global-search branch from 4944c60 to 0275298CompareNovember 28, 2023 16:37
@nfebe
nfebe enabled auto-merge November 28, 2023 16:43
@AndyScherzingerAndyScherzinger mentioned this pull request Nov 29, 2023
3 tasks
- Use stand font of filter tags/chips
- No bold
- Use close icon and no close thick
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@AndyScherzinger
AndyScherzingerforce-pushed the minor-ui-updates-global-search branch 2 times, most recently from fc2cdfb to d972e16CompareNovember 29, 2023 10:45
@AndyScherzinger

Copy link
Copy Markdown
Member

/compile amend /

1 similar comment
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

- Show loading when actually loading, instead of no content
- Change modified label to `Date` as it applies to a bunch of things.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the minor-ui-updates-global-search branch from d972e16 to 1534ba0CompareNovember 29, 2023 12:24
@AndyScherzinger
AndyScherzinger merged commit 8f7a138 into masterNov 29, 2023
@AndyScherzinger
AndyScherzinger deleted the minor-ui-updates-global-search branch November 29, 2023 14:08
@AndyScherzinger

Copy link
Copy Markdown
Member

/backport to stable28

@blizzz

Copy link
Copy Markdown
Member

/backport to stable28

@blizzz

Copy link
Copy Markdown
Member

likely will not backport because of the compiled assets. if they were in a separate commit, only those can be picked with the source changes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

@nfebe@AndyScherzinger@blizzz@artonge@skjnldsv