Uh oh!
There was an error while loading. Please reload this page.
Handle close GlobalSearchModal gracefully - #41792
Merged
Merged
Conversation
ChristophWurst
approved these changes
Nov 28, 2023
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Code looks good. Didn't test
ChristophWurst
commented
Nov 28, 2023
Member
/backport to stable28 |
artonge
approved these changes
Nov 28, 2023
artonge
left a comment
Collaborator
There was a problem hiding this comment.
I think that using the .sync modifier can help in such cases: https://v2.vuejs.org/v2/guide/components-custom-events.html#sync-Modifier
But code looks good like that
nfebeforce-pushed
the
avoid-mutating-prop
branch
from
November 28, 2023 14:29
6f3bf8d to
02525edCompareAndyScherzingerforce-pushed
the
avoid-mutating-prop
branch
from
November 29, 2023 10:08
02525ed to
56c5e75CompareAndyScherzinger
commented
Nov 29, 2023
Member
/compile amend / |
AndyScherzinger
approved these changes
Nov 29, 2023
nextcloud-commandforce-pushed
the
avoid-mutating-prop
branch
from
November 29, 2023 10:22
56c5e75 to
fa27fd3CompareThe current close infrastructure modifies a prop which has no real effect aside bugs. In addition, calling the `NcModal.close()` as the primary way to close the search modal instead of using the states defined in `GlobalSearch` view causing re-open bugs (Modal cannot open, needs to click twice, and other weird stuff). Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzingerforce-pushed
the
avoid-mutating-prop
branch
from
November 29, 2023 14:18
fa27fd3 to
0d938ccCompareAndyScherzinger
commented
Nov 29, 2023
Member
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
approved these changes
Nov 29, 2023
susnux
commented
Nov 29, 2023
Contributor
drone error unrelated |
nfebe pushed a commit
that referenced
this pull request
Nov 29, 2023
Handle close GlobalSearchModal gracefully
nfebe
commented
Nov 29, 2023
ContributorAuthor
/backport to stable28 |
nfebe added a commit
that referenced
this pull request
Nov 30, 2023
[stable28] Handle close GlobalSearchModal gracefully #41792
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorts out re-opening errors, such as needing two clicks after clicking outside, or modal flashes.
The current close infrastructure modifies a prop which has no real effect aside bugs.
In addition, calling the
NcModal.close()as the primary way to close the search modal instead of using the states defined inGlobalSearchview causing re-open bugs (Modal cannot open, needs to click twice, and other weird stuff).Contributes to #41381