Skip to content

fix(theming): Fix color inverted icons based on theming and dark mode - #41855

Merged
nickvergessen merged 2 commits into
masterfrom
bugfix/41352/fix-settings-app-icons
Nov 29, 2023
Merged

fix(theming): Fix color inverted icons based on theming and dark mode#41855
nickvergessen merged 2 commits into
masterfrom
bugfix/41352/fix-settings-app-icons

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Summary

ModeBeforeAfter
Bright mode + text-on-primary "white"Bildschirmfoto vom 2023-11-29 11-23-17Bildschirmfoto vom 2023-11-29 11-26-21
Dark mode + text-on-primary "white"Bildschirmfoto vom 2023-11-29 11-23-23Bildschirmfoto vom 2023-11-29 11-26-17
Bright mode + text-on-primary "black"Bildschirmfoto vom 2023-11-29 11-29-01Bildschirmfoto vom 2023-11-29 11-26-54
Dark mode + text-on-primary "black"Bildschirmfoto vom 2023-11-29 11-28-46Bildschirmfoto vom 2023-11-29 11-26-59

Checklist

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @nickvergessen! :)

Tested and seems to work fine but found one remaining spot where it is broken:
image

@AndyScherzinger

Copy link
Copy Markdown
Member

/backport to stable28

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Found and fixed the user header menu and the arrow-down/up option for the nested share files list:

Bildschirmfoto vom 2023-11-29 11-56-48
Bildschirmfoto vom 2023-11-29 11-58-18

@szaimen

Copy link
Copy Markdown
Contributor

Nodb failure seems related https://drone.nextcloud.com/nextcloud/server/45036/9/4

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/41352/fix-settings-app-icons branch from 45644e7 to d05a13fCompareNovember 29, 2023 15:38
@nickvergessen
nickvergessen merged commit a5a49ff into masterNov 29, 2023
@nickvergessen
nickvergessen deleted the bugfix/41352/fix-settings-app-icons branch November 29, 2023 20:10
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@szaimen

Copy link
Copy Markdown
Contributor

Seems like it didnt work :/

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Compiled assets... will do manually

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings icons are color inverted based on wrong metrix

3 participants

@nickvergessen@AndyScherzinger@szaimen