Skip to content

perf: Use more performant way to obtain and check the email as a login name with token login - #41927

Merged
juliusknorr merged 3 commits into
masterfrom
perf/login-with-email-token
Dec 5, 2023
Merged

perf: Use more performant way to obtain and check the email as a login name with token login#41927
juliusknorr merged 3 commits into
masterfrom
perf/login-with-email-token

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Nov 30, 2023•
edited
Loading

Copy link
Copy Markdown
Member

UserManager::getByEmail is slow on large userbases so we should avoid it where possible.

  • When logging in with a token we first try to verify against the login name passed but then do a second attempt using the email address. As we already know the user id that we need to look up the email for we can use the stored uid from the token and compare the email instead of searching by mail
  • Revert change to always use an sql cast that was a behavioral change from 8bbdd9e between 24 and 25
  • Add a partial index to the configvalue to ensure that most email checks can use an indexed query -> Moved to perf: Add partial index on configvalue of preferences table #42022
    KEY `tmp_configvalue_index` (`configvalue`(80)),
    • OCI doesn't like that index cannot create index on expression with datatype LOB

TODO:

  • Come up with a good approach for adding a test case to avoid future regressions in performance

@juliusknorr
juliusknorrforce-pushed the perf/login-with-email-token branch from b396c27 to f4668c2CompareNovember 30, 2023 15:55
@juliusknorr
juliusknorr requested review from a team, come-nc, icewind1991, kesselb, nfebe and nickvergessen and removed request for a teamNovember 30, 2023 15:55
@nickvergessennickvergessen added this to the Nextcloud 29 milestone Nov 30, 2023
@juliusknorr
juliusknorr marked this pull request as ready for review November 30, 2023 19:50
@juliusknorr
perf: Use more performant way to obtain and check the email as a logi…
a3a343c
…n name with token login
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Only apply cast if needed when searching users for value
3cd1d74
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
perf: Add partial index on configvalue of preferences table
0ccf84b
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the perf/login-with-email-token branch from 381db45 to 0ccf84bCompareNovember 30, 2023 19:51
@juliusknorr

juliusknorr commented Dec 4, 2023

Copy link
Copy Markdown
MemberAuthor

@nickvergessen As discussed via chat, I split out the additional index and moved it to #42022 to not forget about that.

kesselb
kesselb reviewed Dec 4, 2023
View reviewed changes
Comment threadlib/private/User/Session.php
if (!(\count($users) === 1 && $this->login($users[0]->getUID(), $password))) {

if ($isTokenPassword) {
$dbToken = $this->tokenProvider->getToken($password);

@kesselbkesselbDec 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice shortcut ;)

nfebe
nfebe approved these changes Dec 4, 2023
View reviewed changes

@nfebenfebe left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good.

By the way, I think it's helpful to attach the point explanations in the pull request description in the various commit bodies.

@juliusknorr
juliusknorr merged commit 6c52242 into masterDec 5, 2023
@juliusknorr
juliusknorr deleted the perf/login-with-email-token branch December 5, 2023 10:11
@juliusknorr

juliusknorr commented Dec 5, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@juliusknorr

juliusknorr commented Dec 5, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@juliusknorr

juliusknorr commented Dec 5, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@juliusknorr

juliusknorr commented Dec 5, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@nfebe

nfebe commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Automatic backports have failed...

@juliusknorrjuliusknorr mentioned this pull request Dec 6, 2023
Merged
@juliusknorr

juliusknorr commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

/backport a3a343c,3cd1d74a815531c9b7ae25ebbf8e7c45fa566e74 to stable28

@juliusknorr

juliusknorr commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

/backport a3a343c,3cd1d74a815531c9b7ae25ebbf8e7c45fa566e74 to stable27

@juliusknorr

juliusknorr commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

/backport a3a343c,3cd1d74a815531c9b7ae25ebbf8e7c45fa566e74 to stable26

@juliusknorr

juliusknorr commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

/backport a3a343c,3cd1d74a815531c9b7ae25ebbf8e7c45fa566e74 to stable25

This was referenced Jan 9, 2024
Merged
Merged
Merged
Merged
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@nickvergessennickvergessennickvergessen approved these changes
@nfebenfebenfebe approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

2. developingWork in progressbugfeature: authenticationperformance 🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@nfebe@nickvergessen@kesselb