Uh oh!
There was an error while loading. Please reload this page.
fix(files): Fix type issues of mixing string and number - #41952
Closed
susnux wants to merge 1 commit into
Closed
Conversation
susnuxforce-pushed
the
fix/files-typescript-issues
branch
3 times, most recently
from
December 1, 2023 16:57
5858325 to
46a8effCompareartonge
reviewed
Dec 5, 2023
| }, | ||
| computed: { | ||
| currentView(): View { |
ContributorAuthor
There was a problem hiding this comment.
Because it was wrong, the correct type would be View | null as this is the type of Navigation.active .
So the correct typing is inferred.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
reviewed
Dec 6, 2023
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
reviewed
Dec 6, 2023
| window.OCA.Files.Sidebar.setActiveTab('sharing') | ||
| } | ||
| sidebarAction.exec(this.currentFolder, this.currentView, this.currentFolder.path) | ||
| if (this.currentFolder !== undefined) { |
Member
There was a problem hiding this comment.
Seems like there is a lot of unrelated changes?How would this.currentFolder be undefined?The FilesList gets rendered only if we have files, which we have only if this.currentFolder is defined, no? 🤔
EDIT: saw the above changes! 👍
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/files-typescript-issues
branch
from
December 13, 2023 15:52
46a8eff to
050ce4dCompareskjnldsv
commented
Mar 15, 2024
Member
Too much conflicts, closing 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix some type issues in the files list where numbers were mixed with strings for fileids and thus the strict compare will fail (
===).Checklist