Skip to content

fix(TemplateManager): Bail early if templatedirectory is empty - #41995

Merged
nickvergessen merged 1 commit into
masterfrom
fix/template-manager-templatedirectory-empty
Dec 4, 2023
Merged

fix(TemplateManager): Bail early if templatedirectory is empty#41995
nickvergessen merged 1 commit into
masterfrom
fix/template-manager-templatedirectory-empty

Conversation

@marcelklehr

@marcelklehrmarcelklehr commented Dec 4, 2023

Copy link
Copy Markdown
Member

Checklist

@marcelklehr

marcelklehr commented Dec 4, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@marcelklehr

marcelklehr commented Dec 4, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@marcelklehr

marcelklehr commented Dec 4, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

ChristophWurst
ChristophWurst reviewed Dec 4, 2023
View reviewed changes
Comment threadlib/private/Files/Template/TemplateManager.php Outdated
@ChristophWurstChristophWurst added this to the Nextcloud 29 milestone Dec 4, 2023
nickvergessen
nickvergessen reviewed Dec 4, 2023
View reviewed changes
Comment threadlib/private/Files/Template/TemplateManager.php Outdated
ChristophWurst
ChristophWurst approved these changes Dec 4, 2023
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into one

@marcelklehr
fix(TemplateManager): Bail early if templatedirectory is empty
062a0ef
fixes#39266
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
marcelklehrforce-pushed the fix/template-manager-templatedirectory-empty branch from c435eba to 062a0efCompareDecember 4, 2023 07:53
@nickvergessen
nickvergessen merged commit 1066f7e into masterDec 4, 2023
@nickvergessen
nickvergessen deleted the fix/template-manager-templatedirectory-empty branch December 4, 2023 09:39
This was referenced Dec 4, 2023
Merged
Merged
Merged
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: templates

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Possibility to disable "Templates" directory creation in the config file

4 participants

@marcelklehr@nickvergessen@ChristophWurst@juliusknorr