fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english - #42053

Merged

marcelklehr merged 2 commits into

Dec 7, 2023

marcelklehr commented Dec 6, 2023

Member

Resolves: Cannot set user quota with uneven values using locales that use a comma as decimal separator #18468

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

marcelklehr requested review from Pytal and skjnldsv

December 6, 2023 13:10

backportbot-nextcloudBot added the backport-request label

marcelklehr force-pushed the fix/18468 branch from 4667336 to 5ebcc6dCompare

December 6, 2023 13:43

skjnldsv approved these changes

View reviewed changes

Pytal approved these changes

View reviewed changes

marcelklehr commented Dec 6, 2023

MemberAuthor

/backport 5ebcc6d to stable28

marcelklehr commented Dec 6, 2023

MemberAuthor

/backport 5ebcc6d to stable27

marcelklehr commented Dec 6, 2023

MemberAuthor

/backport 5ebcc6d to stable26

marcelklehr commented Dec 6, 2023

MemberAuthor

/compile

marcelklehr enabled auto-merge

December 6, 2023 19:05

marcelklehr force-pushed the fix/18468 branch from 2f05163 to 5ebcc6dCompare

December 7, 2023 08:56

fix(Users/Quota setting): Prevent floating point value from getting t…

162f801

…runcated in locales other than english
fixes#18468
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr force-pushed the fix/18468 branch from 5ebcc6d to 162f801Compare

December 7, 2023 08:57

marcelklehr commented Dec 7, 2023

MemberAuthor

/compile

1 similar comment

marcelklehr commented Dec 7, 2023

MemberAuthor

/compile

chore(assets): Recompile assets

0f667d2

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

skjnldsv reviewed

View reviewed changes

apps/settings/src/components/Users/UserRow.vue

 import UserRowMixin from '../../mixins/UserRowMixin.js'
 import { isObfuscated, unlimitedQuota } from '../../utils/userUtils.ts'
+import {formatFileSize, parseFileSize} from "@nextcloud/files";

skjnldsvDec 7, 2023•
edited
Loading

Member

Suggested change

import {formatFileSize, parseFileSize} from "@nextcloud/files";
import {formatFileSize, parseFileSize} from '@nextcloud/files'

marcelklehr merged commit 7b6877b into master

marcelklehr deleted the fix/18468 branch

December 7, 2023 13:21

marcelklehr commented Dec 7, 2023

MemberAuthor

/backport 162f801 to stable28

marcelklehr commented Dec 7, 2023

MemberAuthor

/backport 162f801 to stable27

marcelklehr commented Dec 7, 2023

MemberAuthor

/backport 162f801 to stable26

marcelklehr commented Dec 7, 2023

MemberAuthor

/backport 162f801 to stable28

backportbot-nextcloudBot mentioned this pull request

[stable28] fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english #42106

Merged

backportbot-nextcloudBot removed the backport-request label

marcelklehr commented Dec 7, 2023•
edited
Loading

MemberAuthor

/backport 162f801 to stable27

marcelklehr commented Dec 7, 2023

MemberAuthor

/backport 162f801 to stable27

backportbot-nextcloudBot added the backport-request label

marcelklehr commented Dec 7, 2023

MemberAuthor

/backport 162f801 to stable26

marcelklehr commented Dec 7, 2023

MemberAuthor

/backport 162f801 to stable27

marcelklehr commented Dec 12, 2023

MemberAuthor

/backport 162f801 to stable27

skjnldsv mentioned this pull request

fix(settings): set default or unlimited user quota #42723

Merged

blizzz added this to the Nextcloud 28 milestone

blizzz mentioned this pull request

29.0.0 beta 1 #43991

Merged

skjnldsv removed the backport-request label

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment