Skip to content

feat(settings): add occ commands to handle admin delegation - #42064

Merged
Altahrim merged 1 commit into
masterfrom
feat/settings/add-delegation-commands
Dec 13, 2023
Merged

feat(settings): add occ commands to handle admin delegation#42064
Altahrim merged 1 commit into
masterfrom
feat/settings/add-delegation-commands

Conversation

@Altahrim

@AltahrimAltahrim commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

Summary

Add commands to handle admin delegation settings:

  • settings:admin-delegation:show: show current delegation
  • settings:admin-delegation:add: add a delegation to a group
  • settings:admin-delegation:remove: remove a delegation from a group

Checklist

@Altahrim
Altahrim requested a review from a teamDecember 6, 2023 15:21
@AltahrimAltahrim self-assigned this Dec 6, 2023
@Altahrim
Altahrim requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a teamDecember 6, 2023 16:13
artonge
artonge requested changes Dec 6, 2023
View reviewed changes
Comment threadapps/settings/lib/Command/AdminDelegation/Remove.php Outdated
Comment threadapps/settings/lib/Command/AdminDelegation/Add.php Outdated
Pytal
Pytal reviewed Dec 6, 2023
View reviewed changes
Comment threadapps/settings/lib/Command/AdminDelegation/Add.php Outdated
Comment threadapps/settings/lib/Command/AdminDelegation/Remove.php Outdated
Comment threadapps/settings/lib/Command/AdminDelegation/Show.php Outdated
Comment threadapps/settings/lib/Command/AdminDelegation/Add.php Outdated
Comment threadapps/settings/lib/Command/AdminDelegation/Remove.php Outdated
Comment threadapps/settings/lib/Command/AdminDelegation/Show.php
come-nc
come-nc reviewed Dec 7, 2023
View reviewed changes
Comment threadapps/settings/lib/Command/AdminDelegation/Show.php Outdated
@Altahrim
Altahrimforce-pushed the feat/settings/add-delegation-commands branch from d04bae7 to 0bef261CompareDecember 7, 2023 14:17
come-nc
come-nc approved these changes Dec 7, 2023
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@blizzzblizzz added this to the Nextcloud 29 milestone Dec 12, 2023
@Altahrim
feat(settings): add occ commands to handle admin delegation
208e6bc
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrimforce-pushed the feat/settings/add-delegation-commands branch from 0bef261 to 208e6bcCompareDecember 13, 2023 08:25
@AltahrimAltahrim added the pending documentation This pull request needs an associated documentation update label Dec 13, 2023
@Altahrim
Altahrim merged commit 6077f26 into masterDec 13, 2023
@Altahrim
Altahrim deleted the feat/settings/add-delegation-commands branch December 13, 2023 09:06
@Altahrim

Altahrim commented Dec 13, 2023

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable28

@AltahrimAltahrim mentioned this pull request Dec 13, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
@AltahrimAltahrim removed the pending documentation This pull request needs an associated documentation update label Mar 31, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@PytalPytalPytal approved these changes
@come-nccome-nccome-nc approved these changes
@JuliaKirschenheuterJuliaKirschenheuterAwaiting requested review from JuliaKirschenheuter
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

feature: settings

Projects

📁 Files team
Archived in project

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

5 participants

@Altahrim@artonge@Pytal@come-nc@blizzz