Uh oh!
There was an error while loading. Please reload this page.
Tooltip outside click, should abort share creation - #42126
Merged
Conversation
nfebe
marked this pull request as draft
December 8, 2023 16:24
nfebe
marked this pull request as ready for review
December 8, 2023 17:06
nfebeforce-pushed
the
click-outside-should-abort-share
branch
from
December 8, 2023 17:07
c591790 to
98ee9d6Compare8 tasks
artonge
requested changes
Dec 11, 2023
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Some files seem unrelated
Uh oh!
There was an error while loading. Please reload this page.
It's unexpected that click outside a tooltip would proceed with the action that could be carried out inside the tooltip. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebeforce-pushed
the
click-outside-should-abort-share
branch
from
December 11, 2023 20:03
98ee9d6 to
41061ddCompareDebounce `onExpirationChange` to avoid calling `formatDateToString` on invalid on uncompletely inputed date strings. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebeforce-pushed
the
click-outside-should-abort-share
branch
from
December 11, 2023 20:06
41061dd to
04e8733Comparenfebe
commented
Dec 11, 2023
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
artonge
approved these changes
Dec 11, 2023
susnux
approved these changes
Dec 12, 2023
nfebe
commented
Dec 12, 2023
ContributorAuthor
/backport to stable28 |
nfebe
commented
Dec 12, 2023
ContributorAuthor
/backport to stable27 |
nfebe
commented
Dec 13, 2023
ContributorAuthor
/backport to stable28 |
nfebe
commented
Dec 13, 2023
ContributorAuthor
/backport to stable27 |
skjnldsv
commented
Jan 15, 2024
Member
1 task
skjnldsv
commented
Jan 15, 2024
Member
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves : #42046, #42114