fix(caldav): don't reuse query builder objects

[miaulalala]

• Resolves:

Summary

Reusing query builder objects causes a Doctrine\DBAL\Query\QueryException

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[miaulalala]

/backport to stable28

[miaulalala]

/backport to stable27

[miaulalala]

/backport to stable26

[ChristophWurst]

Makes sense!

What I find suspicious is that this is described as a regression, like the feature broke recently. But the QB recyling has happened since the feature was added in 30d13bb.

[ChristophWurst]

7f0a54c only logs a warning but doesn't abort.
While the qb recyling is really ugly here, I think it worked because discarding the previous WHEREs for every recycle is fine 🤔

[tcitworld]

Yeah, I think it's unlikely this will fix #42143, but they can try to apply the simple patch.

[ChristophWurst]

Fine by me but won't help with #42143

[X-Raph-X]

Hi, I've patched my NC28.0.0 because I have the issue #42143 . I confirm the issue is NOT solved by this commit.