handle copy of live photos

[ArtificialOwl]

• uses of handleMove() during the BeforeNodeCopiedEvent to check the doability of copying both files.
• handleCopy() called during the NodeCopiedEvent to generate a copy of the linked file.

[ArtificialOwl]

/backport to stable28

[icewind1991]

storing a reference seems pretty hacky to me and an easy way to introduce weirdness down the line.

I would prefer to pass $run by value and then update $arguments['run'] after the hook is dispatched.
It's more code but the intent is clearer to me.

[artonge]

How can the listener gives the new value of $run back to the emitter?

[icewind1991]

add a getter so HookConnector can retrieve it

[artonge]

That sounds smart. @ArtificialOwl will you have the time to update the other event listeners too ? :D

[skjnldsv]

@ArtificialOwl 👀

[ArtificialOwl]

Tested few other ways but the simplest seems to have the HookController catching new event AbortedEventException and update $arguments['run']. Throwing the exception also stop the event propagation.

@icewind1991@artonge please re-review

[ArtificialOwl]

thanks @icewind1991
fixed last comment, squashed & rebased

[backportbot]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/42170/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 467c84ec
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42170/stable28

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[ArtificialOwl]

@artonge based on the size of the changes and the need for this feature, do we want to backport to 28 ?

[artonge]

I would say no, but not for me to decide, @sorbaugh

[squid-f]

Hi. Just updated to 29.0.3 and the error persists :
AbortedEventException Cannot delete the video part of a live photo delete process aborted

[kesselb]

/backport to stable28

[backportbot]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/42170/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 467c84ec
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42170/stable28

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.