Skip to content

Don't list on public calendar endpoints - #4224

Merged
MorrisJobke merged 1 commit into
masterfrom
dont-list-on-public-calendar-endpoint
Apr 6, 2017
Merged

Don't list on public calendar endpoints#4224
MorrisJobke merged 1 commit into
masterfrom
dont-list-on-public-calendar-endpoint

Conversation

@LukasReschke

Copy link
Copy Markdown
Member

There is no need to allow listing here.

Signed-off-by: Lukas Reschke lukas@statuscode.ch

There is no need to allow listing here.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschkeLukasReschke added the 3. to review Waiting for reviews label Apr 5, 2017
@LukasReschkeLukasReschke added this to the Nextcloud 12.0 milestone Apr 5, 2017
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #4224 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #4224 +/- ##
============================================
- Coverage 54.04% 54.04% -0.01% + Complexity 21304 21303 -1 
============================================
Files 1259 1259 Lines 74243 74240 -3 ============================================
- Hits 40124 40122 -2 + Misses 34119 34118 -1
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/CalDAV/PublicCalendarRoot.php100% <100%> (ø)4 <0> (-1)⬇️
lib/private/Server.php92.98% <0%> (-0.15%)120% <0%> (ø)
apps/files_external/lib/Lib/Storage/SMB.php47.22% <0%> (+0.39%)112% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php93.81% <0%> (+1.03%)38% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56797fd...63288eb. Read the comment docs.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit b084cee into masterApr 6, 2017
@MorrisJobke
MorrisJobke deleted the dont-list-on-public-calendar-endpoint branch April 6, 2017 01:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasReschke@codecov-io@MorrisJobke@georgehrke