Skip to content

[stable26] fix(dav): allow multiple organizers if possible - #42376

Merged
ChristophWurst merged 1 commit into
stable26from
backport/42339/stable26
Jan 2, 2024
Merged

[stable26] fix(dav): allow multiple organizers if possible#42376
ChristophWurst merged 1 commit into
stable26from
backport/42339/stable26

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

Backport of #42339

throw $e;
}

$addresses = $this->getAddressesForPrincipal($calendarNode->getOwner());

Check notice

Code scanning / Psalm

PossiblyNullArgument

Argument 1 of OCA\DAV\CalDAV\Schedule\Plugin::getAddressesForPrincipal cannot be null, possibly null value provided
This is very hacky! However, we want to allow saving events with multiple
organizers. Those events are not RFC compliant, but sometimes imported from major
external calendar services (e.g. Google). If the current user is not an organizer of
the event we ignore the exception as no scheduling messages will be sent anyway.
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the backport/42339/stable26 branch from aa3aa81 to de3d390CompareJanuary 2, 2024 10:56
@st3inyst3iny added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 2, 2024
@ChristophWurst
ChristophWurst merged commit 8f69467 into stable26Jan 2, 2024
@ChristophWurst
ChristophWurst deleted the backport/42339/stable26 branch January 2, 2024 13:07
@blizzzblizzz mentioned this pull request Jan 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: caldavRelated to CalDAV internalsfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@st3iny@miaulalala@github-advanced-security@ChristophWurst