Uh oh!
There was an error while loading. Please reload this page.
fix(files): move focus to sidebar on open - #42444
Merged
Merged
Conversation
ShGKmeforce-pushed
the
fix/41877/files--move-focus-to-sidebar-on-open
branch
from
February 7, 2024 01:38
8656a08 to
027868eCompareShGKmeforce-pushed
the
fix/41877/files--move-focus-to-sidebar-on-open
branch
from
February 7, 2024 01:44
027868e to
4ec2ba6Compare2 tasks
JuliaKirschenheuter
approved these changes
Feb 7, 2024
JuliaKirschenheuter
left a comment
Contributor
There was a problem hiding this comment.
Works great too! Thank you!
JuliaKirschenheuter
marked this pull request as ready for review
February 7, 2024 09:25
JuliaKirschenheuter
commented
Feb 7, 2024
Contributor
/compile / |
emoral435
approved these changes
Feb 7, 2024
emoral435
left a comment
Contributor
There was a problem hiding this comment.
Outside of a minor nitpick, LGTM! 🐘💙
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
This PR requires |
ShGKmeforce-pushed
the
fix/41877/files--move-focus-to-sidebar-on-open
branch
2 times, most recently
from
February 7, 2024 15:35
608e7d5 to
a70c3deCompareskjnldsv
reviewed
Feb 7, 2024
| :close-after-click="!isMenu(action.id)" | ||
| :data-cy-files-list-row-action="action.id" | ||
| :is-menu="isMenu(action.id)" | ||
| :aria-label="mountType === 'shared' && action.id === 'sharing-status' ? action.title([source]) : actionDisplayName(action)" |
Member
There was a problem hiding this comment.
That seems really specific, where is this coming from and what does it have to do with that PR? :)
ContributorAuthor
There was a problem hiding this comment.
From the next one line (title prop) and the content of the button 7 lines below. I can move it to a new PR, but a button must have a label or text.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
commented
Feb 7, 2024
ContributorAuthor
/backport to stable28 |
ShGKmeforce-pushed
the
fix/41877/files--move-focus-to-sidebar-on-open
branch
from
February 7, 2024 23:05
a70c3de to
17c9f73CompareShGKme
commented
Feb 8, 2024
ContributorAuthor
|
skjnldsv
approved these changes
Feb 8, 2024
JuliaKirschenheuter
commented
Feb 8, 2024
Contributor
/backport to stable28 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See commits for details.
See nextcloud-libraries/nextcloud-vue#5219 for screenshots
Checklist