Fix Slow logout on Chrome-like browsers

[HLFH]

• Resolves: Slow logout on Chrome-like browsers #41196

Summary

It cancels PR #37405, removes all the regression code.
This issue is it has been 9 months than the logout takes 30 seconds on Chrome-like browsers since this PR.
If anything was interesting in the highly damaging PR #37405, I highly recommend to add any feature-related PR in a separate PR, as this one is only meant to fix a critical bug, which makes Nextcloud unusable.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

@karlitschek

[artonge]

Let's keep the HTTPS check :)

[szaimen]

LGTM with the changes by @artonge

[HLFH]

I signed-off your commit. @artonge
I don't know if we need to add anything in LoginControllerTest.php with your commit.

[artonge]

Drone is not triggered. Merging.

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[nickvergessen]

Drone is not triggered. Merging.

Drone is actually red due to this PR:

Runtime: PHP 8.2.14
Configuration: phpunit-autotest.xml
FFF............ 15 / 15 (100%)
Time: 00:00.049, Memory: 30.00 MB
There were 3 failures:
1) Tests\Core\Controller\LoginControllerTest::testLogoutWithoutToken
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
OCP\AppFramework\Http\RedirectResponse Object (
'headers' => Array (
'Location' => '/login'
- 'Clear-Site-Data' => '"cache", "storage"'
)
'cookies' => Array ()
'status' => 303
/home/nickv/Nextcloud/29/server/tests/Core/Controller/LoginControllerTest.php:160
2) Tests\Core\Controller\LoginControllerTest::testLogoutNoClearSiteData
Expectation failed for method name is "isUserAgent" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
3) Tests\Core\Controller\LoginControllerTest::testLogoutWithToken
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
OCP\AppFramework\Http\RedirectResponse Object (
'headers' => Array (
'Location' => '/login'
- 'Clear-Site-Data' => '"cache", "storage"'
)
'cookies' => Array ()
'status' => 303
/home/nickv/Nextcloud/29/server/tests/Core/Controller/LoginControllerTest.php:214

Drone is configured to no longer work on forks due to some security implications.

It is recommended to fork the PR into our org for now when they are good.

Can you follow up to make CI green again?

[HLFH]

@artonge Can this with #42633 be backported for stable-28 branch? For 28.0.3 release :)

[artonge]

/backport to stable28

[artonge]

@HLFH can you ensure that #42633 is included in the created PR?

[susnux]

I think this should have been fixed in the master pr. Instead of excluding Chrome just drop the cache part.

Thats what slows chrome down, because of a 7 years old chrome bug...

[skjnldsv]

👀