Uh oh!
There was an error while loading. Please reload this page.
enh(OCP\Translation): Add ITranslationProviderWithId - #42649
Merged
Conversation
bigcat88
approved these changes
Jan 9, 2024
andrey18106
approved these changes
Jan 9, 2024
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehrforce-pushed
the
enh/machine-translation-provider-with-id
branch
from
January 10, 2024 10:16
296cb5d to
c148f84Comparemarcelklehr
commented
Jan 10, 2024
MemberAuthor
Drone failure seems unrelated |
…tionProvider Signed-off-by: Marcel Klehr <mklehr@gmx.net>
nickvergessen
approved these changes
Jan 10, 2024
marcelklehr
commented
Jan 10, 2024
MemberAuthor
Added ITranslationProviderWithUserId |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehrforce-pushed
the
enh/machine-translation-provider-with-id
branch
from
January 10, 2024 15:00
e9b4df6 to
1db8888Comparenickvergessen
approved these changes
Jan 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
enabled auto-merge
January 11, 2024 08:32
bigcat88
commented
Jan 11, 2024
Member
Can someone use super power to force merge this? |
bigcat88
commented
Jan 11, 2024
Member
Thank you, Julius. |
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In order to allow External Apps to register machine translation providers, we need to allow declaring a getId() method which is used instead of the class name, as app_api will use an anonymous class to register these and all providers would have the same class name.
Checklist