Skip to content

fix(a11y): Fix informative graphics contrast of user status icons - #42732

Merged
Pytal merged 4 commits into
masterfrom
fix/a11y/user-status-icons
Jan 24, 2024
Merged

fix(a11y): Fix informative graphics contrast of user status icons#42732
Pytal merged 4 commits into
masterfrom
fix/a11y/user-status-icons

Conversation

@Pytal

@PytalPytal commented Jan 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Opening for review in advance

Summary

BeforeAfter
imageimage
imageimage
imageimage
imageimage

Checklist

@PytalPytal added this to the Nextcloud 29 milestone Jan 12, 2024
@PytalPytal self-assigned this Jan 12, 2024
ShGKme
ShGKme approved these changes Jan 12, 2024
View reviewed changes
Comment threadapps/user_status/src/UserStatus.vue Outdated
emoral435
emoral435 reviewed Jan 12, 2024
View reviewed changes
Comment threadapps/dashboard/src/DashboardApp.vue
@Pytal
Pytalforce-pushed the fix/a11y/user-status-icons branch from f49e051 to fbd27cbCompareJanuary 16, 2024 18:09
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2024
@AntreesyAntreesy mentioned this pull request Jan 22, 2024
Closed
2 tasks
@nickvergessen

This comment was marked as resolved.

Sign in to view
@Pytal
fix(dashboard): Migrate to NcUserStatusIcon
693eb69
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(user_status): Migrate to NcUserStatusIcon
f060475
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(user_status): Remove unused styles + svgs
b61c13c
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
5945af5
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the fix/a11y/user-status-icons branch from fbd27cb to 5945af5CompareJanuary 24, 2024 00:39
@Pytal

Pytal commented Jan 24, 2024

Copy link
Copy Markdown
MemberAuthor

/backport 693eb69f060475b61c13c to stable28

@Pytal
Pytal enabled auto-merge January 24, 2024 00:43
@Pytal
Pytal disabled auto-merge January 24, 2024 00:58
@Pytal
Pytal enabled auto-merge January 24, 2024 01:04
@Pytal
Pytal merged commit e8a67a7 into masterJan 24, 2024
@Pytal
Pytal deleted the fix/a11y/user-status-icons branch January 24, 2024 01:44
@backportbotbackportbotBot mentioned this pull request Jan 24, 2024
Merged
1 task
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@ShGKmeShGKmeShGKme approved these changes
@szaimenszaimenAwaiting requested review from szaimen
+1 more reviewer
@emoral435emoral435emoral435 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilityfeature: status

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal@nickvergessen@susnux@ShGKme@emoral435