Skip to content

enh(OCP\SpeechToText): Introduce ISpeechToTextProviderWithUserId - #42761

Merged
nickvergessen merged 5 commits into
masterfrom
enh/speech-to-text-provider-with-userid
Feb 13, 2024
Merged

enh(OCP\SpeechToText): Introduce ISpeechToTextProviderWithUserId#42761
nickvergessen merged 5 commits into
masterfrom
enh/speech-to-text-provider-with-userid

Conversation

@andrey18106

Copy link
Copy Markdown
Contributor

Summary

To keep consistency between SpeechToText, TextProcessing, Translation and TextToImage providers introduce IProviderWithUserId.

Checklist

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106andrey18106 changed the title Introduce ISpeechToTextProviderWithUserIdenh(OCP\SpeechToText): Introduce ISpeechToTextProviderWithUserIdJan 14, 2024
Comment threadlib/private/SpeechToText/SpeechToTextManager.php Outdated
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@bigcat88bigcat88 added this to the Nextcloud 29 milestone Jan 14, 2024
@ChristophWurstChristophWurst added pending documentation This pull request needs an associated documentation update 4. to release Ready to be released and/or waiting for tests to finish labels Jan 19, 2024
@bigcat88bigcat88 removed the pending documentation This pull request needs an associated documentation update label Feb 13, 2024
@nickvergessen

Copy link
Copy Markdown
Member

CI is fixed by #43543

@nickvergessennickvergessen added enhancement pending documentation This pull request needs an associated documentation update labels Feb 13, 2024
@bigcat88

Copy link
Copy Markdown
Member

documentation already present for this

@nickvergessen

Copy link
Copy Markdown
Member

@nickvergessen
nickvergessen merged commit f2a7bfd into masterFeb 13, 2024
@nickvergessen
nickvergessen deleted the enh/speech-to-text-provider-with-userid branch February 13, 2024 08:35
@nickvergessen

Copy link
Copy Markdown
Member

documentation already present for this

I see the PR, but not the change on the live page.... maybe building broke?

@nickvergessen

Copy link
Copy Markdown
Member

@nickvergessen

Copy link
Copy Markdown
Member

I see the PR, but not the change on the live page.... maybe building broke?

Ah, merged 1h ago :D

@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementpending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@andrey18106@nickvergessen@bigcat88@marcelklehr@ChristophWurst@tobiasKaminsky