Uh oh!
There was an error while loading. Please reload this page.
fix(Request): Catch exceptions in isTrustedProxy - #42794
Merged
Merged
Conversation
susnux
requested review from
a team, ArtificialOwl, blizzz, icewind1991 and nickvergessen
and removed request for
a teamJanuary 15, 2024 12:21
susnux
commented
Jan 15, 2024
ContributorAuthor
/skjnldsv-backport to stable28 |
susnux
commented
Jan 15, 2024
ContributorAuthor
/skjnldsv-backport to stable27 |
Uh oh!
There was an error while loading. Please reload this page.
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw. But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/invalid-trusted-proxies
branch
from
January 27, 2024 14:00
1401506 to
7620d23Comparenickvergessen
approved these changes
Jan 29, 2024
artonge
approved these changes
Jan 29, 2024
susnux
commented
Jan 29, 2024
ContributorAuthor
/backport to stable28 |
susnux
commented
Jan 29, 2024
ContributorAuthor
/backport to stable27 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw. But as it is used by
getRemoteAddresswhich is used by logging / templating, thrown errors are not reported but silently fail with error 500.Checklist