Uh oh!
There was an error while loading. Please reload this page.
make failure to load app commands non-fatal - #42811
Merged
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, blizzz and nfebe
and removed request for
a teamJanuary 15, 2024 15:30
blizzz
approved these changes
Jan 15, 2024
Uh oh!
There was an error while loading. Please reload this page.
icewind1991force-pushed
the
app-command-load-non-fatal
branch
from
January 16, 2024 14:33
ff5caf0 to
7648b7aCompareicewind1991
commented
Jan 16, 2024
MemberAuthor
/backport to stable28 |
icewind1991
commented
Jan 16, 2024
MemberAuthor
/backport to stable27 |
sorbaugh
approved these changes
Feb 1, 2024
come-nc
approved these changes
Feb 1, 2024
artonge
approved these changes
Feb 1, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
blizzzforce-pushed
the
app-command-load-non-fatal
branch
from
February 2, 2024 12:47
7648b7a to
860caa0Compare
This was referenced Feb 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a command fails to load the occ commands fails with a fatal error. This also prevents using
occ app:disableto disable the offending command.This instead catches the error, logs it and continues loading the commands from other apps.