Skip to content

[stable28] prepare migration to lazy config - #42820

Merged
Altahrim merged 1 commit into
stable28from
enh/noid/prep-appconfig-migration-for-29
Jan 22, 2024
Merged

[stable28] prepare migration to lazy config#42820
Altahrim merged 1 commit into
stable28from
enh/noid/prep-appconfig-migration-for-29

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Jan 15, 2024

Copy link
Copy Markdown
Member

With the changes on AppConfig in NC29 (#41755), this patch will only prep the database for a smoother migration to NC29's.

This patch will avoid error if trying to set/get app config values (also disable/enable apps) between the moment the file are updated and the upgrade is started.

Comment threadcore/Migrations/Version29000Date20231126110901.php Outdated
Comment threadcore/Migrations/Version29000Date20231126110901.php Outdated
@nickvergessen

Copy link
Copy Markdown
Member

Needs a version.php bump so the migration is triggered.
This is also missing in master.

@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/prep-appconfig-migration-for-29 branch from f153563 to e501077CompareJanuary 18, 2024 01:16
@ArtificialOwlArtificialOwl mentioned this pull request Jan 18, 2024
6 tasks
@ArtificialOwl

Copy link
Copy Markdown
MemberAuthor

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/prep-appconfig-migration-for-29 branch from e501077 to 7b6b358CompareJanuary 22, 2024 12:33
@AltahrimAltahrim added this to the Nextcloud 28.0.2 milestone Jan 22, 2024
@AltahrimAltahrim mentioned this pull request Jan 22, 2024
@Altahrim
Altahrim merged commit 2be4fb7 into stable28Jan 22, 2024
@Altahrim
Altahrim deleted the enh/noid/prep-appconfig-migration-for-29 branch January 22, 2024 14:58
@nickvergessen

Copy link
Copy Markdown
Member

Block merges during freezes

🙈

@szaimen

szaimen commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Edit: nwvermind. This patch fixes the migration that was formerly not possible.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ArtificialOwl@nickvergessen@szaimen@Altahrim@artonge