Uh oh!
There was an error while loading. Please reload this page.
fix(settings): set viewBox on SVG icons - #42822
Merged
Merged
Conversation
ShGKme
commented
Jan 16, 2024
ContributorAuthor
/backport 6179aed stable28 |
This comment was marked as off-topic.
This comment was marked as off-topic.
artonge
approved these changes
Jan 16, 2024
ShGKme
commented
Jan 16, 2024
ContributorAuthor
Drone is not related, I cannot restart it... |
Pytal
approved these changes
Jan 16, 2024
ShGKmeforce-pushed
the
fix/settings-svg-viewBox
branch
from
January 21, 2024 21:50
9bed849 to
b3611eaCompareShGKme
enabled auto-merge
January 21, 2024 21:50
Without viewBox they don't scale Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> chore(assets): Recompile assets Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKmeforce-pushed
the
fix/settings-svg-viewBox
branch
from
January 22, 2024 22:54
b3611ea to
51c45b5CompareShGKme
commented
Jan 23, 2024
ContributorAuthor
/backport f5ec894 stable28 |
ShGKme
commented
Jan 23, 2024
ContributorAuthor
/backport f5ec894 to stable28 |
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added missing
viewBoxto SVG icons in settings. WithoutviewBoxthey don't scale.For example, on the Users page when there are no users.
No changes in other places.
Checklist